try to fix transfem-org#118

when fetching notes from Redis, we need to re-check the criteria from the API request, because `userTimelineWithFiles`, `userTimelineWithReplies`, `userTimelineWithChannel` all get merged together, so `noteIds` may well contain notes without attachments…
dakkar · Oct 31, 2023 · 111863b · 111863b
1 parent 9de6e0a
commit 111863b
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/packages/backend/src/server/api/endpoints/users/notes.ts b/packages/backend/src/server/api/endpoints/users/notes.ts
@@ -123,6 +123,8 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
 							}
 						}
 
+						if (ps.withFiles && !note.fileIds) return false;
+
 						if (note.channel?.isSensitive && !isSelf) return false;
 						if (note.visibility === 'specified' && (!me || (me.id !== note.userId && !note.visibleUserIds.some(v => v === me.id)))) return false;
 						if (note.visibility === 'followers' && !isFollowing && !isSelf) return false;