Enhance LocalModule when no go sources found in project root #192

petr-korobeinikov · 2024-03-02T11:26:06Z

👋

Four days ago, a remarkable feature was added — LocalModule. It's an incredibly cool addition that has proven to be useful to many, including myself and my teams.

However, there might be instances where the Go source files are not located in the project's root folder. I've demonstrated what this could look like in a test.

Such an enhancement would be very beneficial. I'm eager to receive feedback from the community and, if possible, apply the suggested improvement.

pkg/section/local_module.go

daixiang0 · 2024-03-04T02:56:42Z

Please fix DCO as well.

petr-korobeinikov · 2024-03-04T13:57:41Z

Please fix DCO as well.

Signed.

daixiang0 · 2024-03-05T01:19:56Z

Codes looks good to me.

In case the minimum reproducible example in #193 is not covered, please wait it and update tests if necessary, then we can make it land.

matthewhughes934

Thanks for fixing this up, and nice work on the extra tests! Since making the change I started having doubts whether the package listing approach was best (:facepalm: I should've added more tests)

matthewhughes934 · 2024-03-06T12:12:57Z

pkg/gci/testdata/module_canonical/.gitattributes

This could probably just be moved up to pkg/gci/testdata to avoid the need to repeat it in each subdir

On one hand, it's a good idea because it eliminates duplicating identical attributes.

On the other hand, such files may be present at the core of the current project, and in this case, they simulate a real repository quite well.

Should we still remove them?

matthewhughes934 · 2024-03-06T12:17:53Z

pkg/section/local_module.go

 			return nil, fmt.Errorf("error reading local packages: %v", pkg.Errors)
 		}
 		if pkg.Module != nil {
 			uniqueModules[pkg.Module.Path] = struct{}{}
+		} else {


🤔 is life easier if we just check for go.mod before even listing local packages? I imagine the most common use case is running from the top-level where go.mod exists + reading go.mod should be cheaper than loading packages (and if we load a module there we could probably just bail out and not even bother listing packages)

All of this is due to the inconsistency of the API provided by the packages package.

I also relied on such behavior of the packages.Load() function. As it seems to me, the fix should be made directly in Go itself.

I don't mind changing the order, especially since we have tests.

We can raise this issue in the GO upstream itself.

Ok, got it. The "packages" package is intended to deal with packages, not with modules itself. So, there is no issue. Proposed a new commit with go.mod processing.

petr-korobeinikov · 2024-03-06T12:51:21Z

Thanks for fixing this up, and nice work on the extra tests! Since making the change I started having doubts whether the package listing approach was best (:facepalm: I should've added more tests)

Don't worry about it. The changes resolved a real existing issue. It's difficult to get everything right on the first try, even with tests.

matthewhughes934 · 2024-03-06T13:19:52Z

In case the minimum reproducible example in #193 is not covered, please wait it and update tests if necessary, then we can make it land.

I think one of the added test cases can be used to reproduce:

$ git clone https://github.com/petr-korobeinikov/gci.git
$ git switch localmodule
$ cd gci/pkg/gci/testdata/module_canonical/
$ go install github.com/daixiang0/[email protected] # make sure we run using the version with the bug
$ gci write -s standard -s default -s localmodule cmd/client/main.go 
Error: error reading local packages: [-: no Go files in /tmp/gci/pkg/gci/testdata/module_canonical]
Usage:
...

petr-korobeinikov · 2024-03-08T07:23:18Z

As of force push of windows error check the pipeline needs to be retriggered.

matthewhughes934

You might need to run go mod tidy since golang.org/x/mod/modfile was previously only an indirect dependency

Pedantic point: but the readme might need updating too remove mention of package listing:

diff --git a/README.md b/README.md
index 0f37fa5..b68248d 100644
--- a/README.md
+++ b/README.md
@@ -50,8 +50,8 @@ Since v0.9.0, GCI always puts C import block as the first.
 
 ### LocalModule
 
-Local module detection is done via listing packages from *the directory where
-`gci` is invoked* and reading the modules off these. This means:
+Local module detection is done via reading the module name from the `go.mod`
+file in *the directory where `gci` is invoked*. This means:
 
   - This mode works when `gci` is invoked from a module root (i.e. directory
     containing `go.mod`)

matthewhughes934 · 2024-03-08T08:42:58Z

pkg/section/local_module.go

 	}

-	return modPaths, nil
+	return modfile.ModulePath(b), nil


Do we need to handle the case where ModulePath returns ""? That is (from https://pkg.go.dev/golang.org/x/mod/modfile#ModulePath)

If it cannot find a module path, it returns an empty string

I think this would only happen if go.mod was invalid and/or missing a module directive, so I expect more things would be going wrong. But maybe still worth returning an error like "could not read module from go.mod"?

pkg/section/local_module.go

petr-korobeinikov · 2024-03-08T09:40:40Z

Looks like PR polished for now. Any suggestions in grammar/syntax on comments, variable naming? Should I squash all commits in one?

matthewhughes934

Thanks again for the fix!

CarlosRDomin · 2024-03-12T00:27:58Z

Is there anything missing to get this merged?

daixiang0 · 2024-03-12T01:01:46Z

Please fix DCO then we can make it land.

Signed-off-by: Petr Korobeinikov <[email protected]>

petr-korobeinikov · 2024-03-12T04:06:24Z

Please fix DCO then we can make it land.

Squashed. Signed off.

daixiang0

LGTM

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/daixiang0/gci](https://togithub.com/daixiang0/gci) | `v0.12.3` -> `v0.13.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdaixiang0%2fgci/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdaixiang0%2fgci/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdaixiang0%2fgci/v0.12.3/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdaixiang0%2fgci/v0.12.3/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>daixiang0/gci (github.com/daixiang0/gci)</summary> ### [`v0.13.1`](https://togithub.com/daixiang0/gci/releases/tag/v0.13.1) [Compare Source](https://togithub.com/daixiang0/gci/compare/v0.13.0...v0.13.1) #### What's Changed - Enhance LocalModule when no go sources found in project root by [@petr-korobeinikov](https://togithub.com/petr-korobeinikov) in [https://github.com/daixiang0/gci/pull/192](https://togithub.com/daixiang0/gci/pull/192) #### New Contributors - [@petr-korobeinikov](https://togithub.com/petr-korobeinikov) made their first contribution in [https://github.com/daixiang0/gci/pull/192](https://togithub.com/daixiang0/gci/pull/192) **Full Changelog**: daixiang0/gci@v0.13...v0.13.1 ### [`v0.13.0`](https://togithub.com/daixiang0/gci/releases/tag/v0.13.0) [Compare Source](https://togithub.com/daixiang0/gci/compare/v0.12.3...v0.13.0) #### What's Changed - Add basic attempt at local module handling by [@matthewhughes934](https://togithub.com/matthewhughes934) in [https://github.com/daixiang0/gci/pull/179](https://togithub.com/daixiang0/gci/pull/179) - Bump up to 0.13 by [@daixiang0](https://togithub.com/daixiang0) in [https://github.com/daixiang0/gci/pull/190](https://togithub.com/daixiang0/gci/pull/190) #### New Contributors - [@matthewhughes934](https://togithub.com/matthewhughes934) made their first contribution in [https://github.com/daixiang0/gci/pull/179](https://togithub.com/daixiang0/gci/pull/179) **Full Changelog**: daixiang0/gci@v0.12.3...v0.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>

* [chore] Remove use of deprecated configtls structs (#31814) * fix(deps): update module google.golang.org/api to v0.170.0 (#31834) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google.golang.org/api](https://togithub.com/googleapis/google-api-go-client) | `v0.167.0` -> `v0.170.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fapi/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fapi/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fapi/v0.167.0/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fapi/v0.167.0/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/api](https://togithub.com/googleapis/google-api-go-client) | `v0.166.0` -> `v0.170.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fapi/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fapi/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fapi/v0.166.0/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fapi/v0.166.0/v0.170.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleapis/google-api-go-client (google.golang.org/api)</summary> ### [`v0.170.0`](https://togithub.com/googleapis/google-api-go-client/releases/tag/v0.170.0) [Compare Source](https://togithub.com/googleapis/google-api-go-client/compare/v0.169.0...v0.170.0) ##### Features - **all:** Auto-regenerate discovery clients ([#2458](https://togithub.com/googleapis/google-api-go-client/issues/2458)) ([fb2b816](https://togithub.com/googleapis/google-api-go-client/commit/fb2b816b756c5b8bc80f5485ad93d710fdfdb6ea)) - **all:** Auto-regenerate discovery clients ([#2460](https://togithub.com/googleapis/google-api-go-client/issues/2460)) ([dc4811a](https://togithub.com/googleapis/google-api-go-client/commit/dc4811aa3cfdf120544f3e2eddd1962a56794a08)) - **all:** Auto-regenerate discovery clients ([#2461](https://togithub.com/googleapis/google-api-go-client/issues/2461)) ([e938bf1](https://togithub.com/googleapis/google-api-go-client/commit/e938bf17ecd2b8430d95b7adb066f9a35f03dceb)) - **all:** Auto-regenerate discovery clients ([#2464](https://togithub.com/googleapis/google-api-go-client/issues/2464)) ([c3a2f34](https://togithub.com/googleapis/google-api-go-client/commit/c3a2f34ee8091bf1aab9f9a44d38a42f40d5a81d)) - **all:** Auto-regenerate discovery clients ([#2466](https://togithub.com/googleapis/google-api-go-client/issues/2466)) ([de61eb7](https://togithub.com/googleapis/google-api-go-client/commit/de61eb772c1f4b91bf46934101331953c82f3d96)) - **all:** Auto-regenerate discovery clients ([#2468](https://togithub.com/googleapis/google-api-go-client/issues/2468)) ([67f16b6](https://togithub.com/googleapis/google-api-go-client/commit/67f16b6ada0cd92d94d98bb32f3bec61ca3472c6)) - **all:** Auto-regenerate discovery clients ([#2471](https://togithub.com/googleapis/google-api-go-client/issues/2471)) ([5537676](https://togithub.com/googleapis/google-api-go-client/commit/5537676cf7a165ff492701a368b94c11511d2929)) ### [`v0.169.0`](https://togithub.com/googleapis/google-api-go-client/releases/tag/v0.169.0) [Compare Source](https://togithub.com/googleapis/google-api-go-client/compare/v0.168.0...v0.169.0) ##### Features - **all:** Auto-regenerate discovery clients ([#2450](https://togithub.com/googleapis/google-api-go-client/issues/2450)) ([d22da18](https://togithub.com/googleapis/google-api-go-client/commit/d22da1806db891da12d7290ef4334e18fbaf0ca2)) - **all:** Auto-regenerate discovery clients ([#2454](https://togithub.com/googleapis/google-api-go-client/issues/2454)) ([2675c0a](https://togithub.com/googleapis/google-api-go-client/commit/2675c0abf9e442bb3ac35e18ecc196aaaa4facd3)) - **all:** Auto-regenerate discovery clients ([#2457](https://togithub.com/googleapis/google-api-go-client/issues/2457)) ([a488112](https://togithub.com/googleapis/google-api-go-client/commit/a488112cd111b883dfaffa7e4ab67e99a6ea9b90)) ### [`v0.168.0`](https://togithub.com/googleapis/google-api-go-client/releases/tag/v0.168.0) [Compare Source](https://togithub.com/googleapis/google-api-go-client/compare/v0.167.0...v0.168.0) ##### Features - **all:** Auto-regenerate discovery clients ([#2431](https://togithub.com/googleapis/google-api-go-client/issues/2431)) ([e635a5e](https://togithub.com/googleapis/google-api-go-client/commit/e635a5e61572ec4a7dbad19a9e32ab7918cde9f0)) - **all:** Auto-regenerate discovery clients ([#2433](https://togithub.com/googleapis/google-api-go-client/issues/2433)) ([0c30ecc](https://togithub.com/googleapis/google-api-go-client/commit/0c30ecca06ff770fafce74743b0a038122e31813)) - **all:** Auto-regenerate discovery clients ([#2436](https://togithub.com/googleapis/google-api-go-client/issues/2436)) ([4dc71d4](https://togithub.com/googleapis/google-api-go-client/commit/4dc71d4531deeb116af23cd13245ca644f0be991)) - **all:** Auto-regenerate discovery clients ([#2438](https://togithub.com/googleapis/google-api-go-client/issues/2438)) ([d290e18](https://togithub.com/googleapis/google-api-go-client/commit/d290e1861655087f52294c6e4994688cbfb3098a)) - **all:** Auto-regenerate discovery clients ([#2442](https://togithub.com/googleapis/google-api-go-client/issues/2442)) ([9f9c0cf](https://togithub.com/googleapis/google-api-go-client/commit/9f9c0cf59e864281bd8b04319e4ce4c3914e147c)) - **all:** Auto-regenerate discovery clients ([#2443](https://togithub.com/googleapis/google-api-go-client/issues/2443)) ([ced0c09](https://togithub.com/googleapis/google-api-go-client/commit/ced0c099be7b1bfa2802567f2a6e57b69b29285e)) - **all:** Auto-regenerate discovery clients ([#2445](https://togithub.com/googleapis/google-api-go-client/issues/2445)) ([4fa90c9](https://togithub.com/googleapis/google-api-go-client/commit/4fa90c93dd04c64c6e1a35b358a23cb014be0e7a)) - **all:** Auto-regenerate discovery clients ([#2447](https://togithub.com/googleapis/google-api-go-client/issues/2447)) ([022c85c](https://togithub.com/googleapis/google-api-go-client/commit/022c85c3d443e58228ea3eb51ee621f2a20d3a45)) - **all:** Auto-regenerate discovery clients ([#2448](https://togithub.com/googleapis/google-api-go-client/issues/2448)) ([af383c7](https://togithub.com/googleapis/google-api-go-client/commit/af383c78468f5129b2333ad7222fb361873a4cd4)) - **all:** Auto-regenerate discovery clients ([#2449](https://togithub.com/googleapis/google-api-go-client/issues/2449)) ([b438981](https://togithub.com/googleapis/google-api-go-client/commit/b43898129eca3b710c3573c48672b73a46ea9cdc)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * fix(deps): update module github.com/sijms/go-ora/v2 to v2.8.10 (#31826) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/sijms/go-ora/v2](https://togithub.com/sijms/go-ora) | `v2.8.9` -> `v2.8.10` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsijms%2fgo-ora%2fv2/v2.8.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsijms%2fgo-ora%2fv2/v2.8.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsijms%2fgo-ora%2fv2/v2.8.9/v2.8.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsijms%2fgo-ora%2fv2/v2.8.9/v2.8.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sijms/go-ora (github.com/sijms/go-ora/v2)</summary> ### [`v2.8.10`](https://togithub.com/sijms/go-ora/releases/tag/v2.8.10): : fix issues related to numbers and select for update [Compare Source](https://togithub.com/sijms/go-ora/compare/v2.8.9...v2.8.10) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * fix(deps): update module cloud.google.com/go/spanner to v1.60.0 (#31827) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cloud.google.com/go/spanner](https://togithub.com/googleapis/google-cloud-go) | `v1.58.0` -> `v1.60.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/cloud.google.com%2fgo%2fspanner/v1.60.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/cloud.google.com%2fgo%2fspanner/v1.60.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/cloud.google.com%2fgo%2fspanner/v1.58.0/v1.60.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/cloud.google.com%2fgo%2fspanner/v1.58.0/v1.60.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * [chore][connector/datadogconnector] Fix connector traceToMetrics lifecycle (#31811) **Description:** Currently, calling `Shutdown` on the `traceToMetricConnector` requires on `Start` being called before, as the `Shutdown` relies on goroutines which are spawned during `Start`. This causes the connector to hang if a call to `Shutdown` is made without a call to `Start`. This PR adds a `isStarted` field to the `traceToMetricConnector` struct, which tracks whether `Start` was called. If it was not, it makes the call to `Shutdown` a no-op. **Link to tracking Issue:** #30487 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Antoine Toulme <[email protected]> * [chore] Remove use of deprecated scraperhelper structs/funcs (#31816) * [exporter/file] add encoding extension support (#31774) **Description:** This adds support to set an encoding extension on the file exporter, overriding the format type. * fix(deps): update module github.com/coreos/go-oidc/v3 to v3.10.0 (#31840) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/coreos/go-oidc/v3](https://togithub.com/coreos/go-oidc) | `v3.9.0` -> `v3.10.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcoreos%2fgo-oidc%2fv3/v3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcoreos%2fgo-oidc%2fv3/v3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcoreos%2fgo-oidc%2fv3/v3.9.0/v3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcoreos%2fgo-oidc%2fv3/v3.9.0/v3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>coreos/go-oidc (github.com/coreos/go-oidc/v3)</summary> ### [`v3.10.0`](https://togithub.com/coreos/go-oidc/releases/tag/v3.10.0) [Compare Source](https://togithub.com/coreos/go-oidc/compare/v3.9.0...v3.10.0) #### What's Changed - fix minor typo by [@bgerrity](https://togithub.com/bgerrity) in [https://github.com/coreos/go-oidc/pull/414](https://togithub.com/coreos/go-oidc/pull/414) - updated github actions by [@ericchiang](https://togithub.com/ericchiang) in [https://github.com/coreos/go-oidc/pull/419](https://togithub.com/coreos/go-oidc/pull/419) - add staticcheck to github actions by [@ericchiang](https://togithub.com/ericchiang) in [https://github.com/coreos/go-oidc/pull/420](https://togithub.com/coreos/go-oidc/pull/420) - update go-jose to v4 by [@ericchiang](https://togithub.com/ericchiang) in [https://github.com/coreos/go-oidc/pull/421](https://togithub.com/coreos/go-oidc/pull/421) #### New Contributors - [@bgerrity](https://togithub.com/bgerrity) made their first contribution in [https://github.com/coreos/go-oidc/pull/414](https://togithub.com/coreos/go-oidc/pull/414) **Full Changelog**: https://github.com/coreos/go-oidc/compare/v3.9.0...v3.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * chore(deps): update wandalen/wretry.action action to v1.4.10 (#31823) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Wandalen/wretry.action](https://togithub.com/Wandalen/wretry.action) | action | patch | `v1.4.9` -> `v1.4.10` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Wandalen/wretry.action (Wandalen/wretry.action)</summary> ### [`v1.4.10`](https://togithub.com/Wandalen/wretry.action/compare/v1.4.9...v1.4.10) [Compare Source](https://togithub.com/Wandalen/wretry.action/compare/v1.4.9...v1.4.10) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module github.com/clickhouse/clickhouse-go/v2 to v2.22.2 (#31828) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | `v2.21.1` -> `v2.22.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1/v2.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1/v2.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.22.2`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2222-2024-03-18----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.22.1...v2.22.2) #### What's Changed ##### Fixes 🐛 - Fix for Map columns with Enums by [@leklund](https://togithub.com/leklund) in [https://github.com/ClickHouse/clickhouse-go/pull/1236](https://togithub.com/ClickHouse/clickhouse-go/pull/1236) #### New Contributors - [@leklund](https://togithub.com/leklund) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1236](https://togithub.com/ClickHouse/clickhouse-go/pull/1236) **Full Changelog**: https://github.com/ClickHouse/clickhouse-go/compare/v2.22.1...v2.22.2 ### [`v2.22.1`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2221-2024-03-18----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.22.0...v2.22.1) #### What's Changed ##### Fixes 🐛 - Make errors channel buffered inside query() by [@threadedstream](https://togithub.com/threadedstream) in [https://github.com/ClickHouse/clickhouse-go/pull/1237](https://togithub.com/ClickHouse/clickhouse-go/pull/1237) **Full Changelog**: https://github.com/ClickHouse/clickhouse-go/compare/v2.22.0...v2.22.1 ### [`v2.22.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.22.0) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.1...v2.22.0)  #### What's Changed ##### Enhancements 🎉 - Experimental streaming SELECT results into batch insert by [@jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1233](https://togithub.com/ClickHouse/clickhouse-go/pull/1233) ##### Fixes 🐛 - Ignore materialized and alias cols infered during HTTP prepare batch by [@iyuroch](https://togithub.com/iyuroch) in [https://github.com/ClickHouse/clickhouse-go/pull/1214](https://togithub.com/ClickHouse/clickhouse-go/pull/1214) #### New Contributors - [@iyuroch](https://togithub.com/iyuroch) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1214](https://togithub.com/ClickHouse/clickhouse-go/pull/1214) **Full Changelog**: https://github.com/ClickHouse/clickhouse-go/compare/v2.21.1...v2.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * chore(deps): update prom/prometheus docker tag to v2.51.0 (#31836) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | prom/prometheus | minor | `v2.50.1` -> `v2.51.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module gonum.org/v1/gonum to v0.15.0 (#31831) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | gonum.org/v1/gonum | `v0.14.0` -> `v0.15.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/gonum.org%2fv1%2fgonum/v0.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/gonum.org%2fv1%2fgonum/v0.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/gonum.org%2fv1%2fgonum/v0.14.0/v0.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/gonum.org%2fv1%2fgonum/v0.14.0/v0.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * fix(deps): update module github.com/daixiang0/gci to v0.13.1 (#31829) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/daixiang0/gci](https://togithub.com/daixiang0/gci) | `v0.12.3` -> `v0.13.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdaixiang0%2fgci/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdaixiang0%2fgci/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdaixiang0%2fgci/v0.12.3/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdaixiang0%2fgci/v0.12.3/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>daixiang0/gci (github.com/daixiang0/gci)</summary> ### [`v0.13.1`](https://togithub.com/daixiang0/gci/releases/tag/v0.13.1) [Compare Source](https://togithub.com/daixiang0/gci/compare/v0.13.0...v0.13.1) #### What's Changed - Enhance LocalModule when no go sources found in project root by [@petr-korobeinikov](https://togithub.com/petr-korobeinikov) in [https://github.com/daixiang0/gci/pull/192](https://togithub.com/daixiang0/gci/pull/192) #### New Contributors - [@petr-korobeinikov](https://togithub.com/petr-korobeinikov) made their first contribution in [https://github.com/daixiang0/gci/pull/192](https://togithub.com/daixiang0/gci/pull/192) **Full Changelog**: https://github.com/daixiang0/gci/compare/v0.13...v0.13.1 ### [`v0.13.0`](https://togithub.com/daixiang0/gci/releases/tag/v0.13.0) [Compare Source](https://togithub.com/daixiang0/gci/compare/v0.12.3...v0.13.0) #### What's Changed - Add basic attempt at local module handling by [@matthewhughes934](https://togithub.com/matthewhughes934) in [https://github.com/daixiang0/gci/pull/179](https://togithub.com/daixiang0/gci/pull/179) - Bump up to 0.13 by [@daixiang0](https://togithub.com/daixiang0) in [https://github.com/daixiang0/gci/pull/190](https://togithub.com/daixiang0/gci/pull/190) #### New Contributors - [@matthewhughes934](https://togithub.com/matthewhughes934) made their first contribution in [https://github.com/daixiang0/gci/pull/179](https://togithub.com/daixiang0/gci/pull/179) **Full Changelog**: https://github.com/daixiang0/gci/compare/v0.12.3...v0.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * [exporter/datadog] Fix data race in metrics exporter shutdown (#31838) **Description:** Fix data race in metrics exporter shutdown. If we do not do `f.wg.Wait()` before closing `statsToAgent`, there can be a race condition when the goroutine still tries to write to `statsToAgent` after it is closed. Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31663 * [connector/datadog] Add container tags (#31642) **Description:** Customers can now set container tags on stats payload computed in DD connector. sample collector config: ``` datadog/connector: traces: resource_attributes_as_container_tags: - "k8s.pod.name" - "cloud.availability_zone" ``` * feat(sumologicextension): enable Sumo Logic Extension (#31478) **Description:** Add Sumo Logic Extension to contrib executable. Fixes #29601 **Link to tracking Issue:** #29601 **Testing:** N/A **Documentation:** `metadata.yaml` --------- Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]> * [receiver/opencensus] refactor the code for maintenance and lifecycle tests (#31648) **Description:** Simplify the code of the opencensus receiver to make it more maintainable, reduce leaks and pass lifecycle tests. **Link to tracking Issue:** Fixes #31643 * Promote the OpAMP extension to alpha stability (#31616) * Update all dd agent pkgs (#31893) **Description:** This PR updates all DD packages to pseudoversion from the [mackjmr/otel/backport](https://github.com/DataDog/datadog-agent/commits/mackjmr/otel/backport/) branch. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> * [chore][awscloudwatchlogsexporter] Enable goleak check (#31891) Description: Enables `goleak` checking on the `awscloudwatchlogsexporter` package. Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30438 Signed-off-by: Israel Blancas <[email protected]> * feat(dockerstats): add online cpu and memory failcnt metrics (#31481) **Description:** two new metrics have been added, they were already being scraped but not emitted **Link to tracking Issue:** #31366 **Testing:** added new metrics to `TestScrapeV2` **Documentation:** generated by mdatagen * [extension/ackextension] Implement in-memory ack extension (#31651) **Description:** Adding the in-memory implementation of the Ack extension proposed in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/26376. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/26376 * [exporter/clickhouse] Update integration tests+readme (#31896) **Description:** Fixed code review nits leftover from #30209 **Testing:** - Added `clickhouse/clickhouse-server:24-alpine` to integration tests **Documentation:** - Added example command for running integration tests * fix(deps): update all github.com/aws packages (#31557) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.50.27` -> `v1.51.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go/v1.51.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go/v1.51.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go/v1.50.27/v1.51.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go/v1.50.27/v1.51.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2](https://togithub.com/aws/aws-sdk-go-v2) | `v1.25.2` -> `v1.26.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2/v1.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2/v1.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2/v1.25.2/v1.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2/v1.25.2/v1.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/config](https://togithub.com/aws/aws-sdk-go-v2) | `v1.27.4` -> `v1.27.8` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.4/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.4/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/config](https://togithub.com/aws/aws-sdk-go-v2) | `v1.27.7` -> `v1.27.8` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.7/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.7/v1.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/credentials](https://togithub.com/aws/aws-sdk-go-v2) | `v1.17.4` -> `v1.17.8` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.4/v1.17.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.4/v1.17.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/service/kinesis](https://togithub.com/aws/aws-sdk-go-v2) | `v1.27.1` -> `v1.27.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fkinesis/v1.27.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fkinesis/v1.27.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fkinesis/v1.27.1/v1.27.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fkinesis/v1.27.1/v1.27.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/service/s3](https://togithub.com/aws/aws-sdk-go-v2) | `v1.51.1` -> `v1.53.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fs3/v1.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fs3/v1.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fs3/v1.51.1/v1.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fs3/v1.51.1/v1.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://togithub.com/aws/aws-sdk-go-v2) | `v1.28.1` -> `v1.28.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.28.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.28.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.28.1/v1.28.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.28.1/v1.28.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://togithub.com/aws/aws-sdk-go-v2) | `v1.29.2` -> `v1.29.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fservicediscovery/v1.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fservicediscovery/v1.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fservicediscovery/v1.29.2/v1.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fservicediscovery/v1.29.2/v1.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/aws/aws-sdk-go-v2/service/sts](https://togithub.com/aws/aws-sdk-go-v2) | `v1.28.1` -> `v1.28.5` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsts/v1.28.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsts/v1.28.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsts/v1.28.1/v1.28.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsts/v1.28.1/v1.28.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.51.3`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1513-2024-03-19) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.51.2...v1.51.3) \=== ##### Service Client Updates - `service/cloudformation`: Updates service documentation - Documentation update, March 2024. Corrects some formatting. - `service/ec2`: Updates service API, documentation, and paginators - This release adds the new DescribeMacHosts API operation for getting information about EC2 Mac Dedicated Hosts. Users can now see the latest macOS versions that their underlying Apple Mac can support without needing to be updated. - `service/finspace`: Updates service API and documentation - `service/logs`: Updates service API and documentation - Update LogSamples field in Anomaly model to be a list of LogEvent - `service/managedblockchain-query`: Updates service API, documentation, and paginators ### [`v1.51.2`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1512-2024-03-18) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.51.1...v1.51.2) \=== ##### Service Client Updates - `service/cloudformation`: Updates service API and documentation - This release supports for a new API ListStackSetAutoDeploymentTargets, which provider auto-deployment configuration as a describable resource. Customers can now view the specific combinations of regions and OUs that are being auto-deployed. - `service/kms`: Updates service API and documentation - Adds the ability to use the default policy name by omitting the policyName parameter in calls to PutKeyPolicy and GetKeyPolicy - `service/mediatailor`: Updates service API and documentation - `service/rds`: Updates service API, documentation, waiters, paginators, and examples - This release launches the ModifyIntegration API and support for data filtering for zero-ETL Integrations. - `service/s3`: Updates service API and examples - Fix two issues with response root node names. - `service/timestream-query`: Updates service documentation ### [`v1.51.1`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1511-2024-03-15) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.51.0...v1.51.1) \=== ##### Service Client Updates - `service/backup`: Updates service API and documentation - `service/codebuild`: Updates service API and documentation - AWS CodeBuild now supports overflow behavior on Reserved Capacity. - `service/connect`: Updates service API and documentation - `service/ec2`: Updates service API and documentation - Add media accelerator and neuron device information on the describe instance types API. - `service/kinesisanalyticsv2`: Updates service API and documentation - `service/s3`: Updates service documentation and examples - Documentation updates for Amazon S3. - `service/sagemaker`: Updates service API and documentation - Adds m6i, m6id, m7i, c6i, c6id, c7i, r6i r6id, r7i, p5 instance type support to Sagemaker Notebook Instances and miscellaneous wording fixes for previous Sagemaker documentation. - `service/workspaces-thin-client`: Updates service API and documentation ### [`v1.51.0`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1510-2024-03-14) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.38...v1.51.0) \=== ##### Service Client Updates - `service/amplify`: Updates service documentation - `service/ec2-instance-connect`: Updates service API and documentation - `service/elasticloadbalancingv2`: Updates service documentation - `service/fis`: Updates service API and documentation - `service/rds`: Updates service API, documentation, waiters, paginators, and examples - Updates Amazon RDS documentation for EBCDIC collation for RDS for Db2. - `service/secretsmanager`: Updates service documentation - Doc only update for Secrets Manager - `service/timestream-influxdb`: Adds new service ##### SDK Features - `service/iotroborunner`: Remove Iotroborunner - This change removes the iotroborunner service, since it is deprecated. ### [`v1.50.38`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15038-2024-03-13) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.37...v1.50.38) \=== ##### Service Client Updates - `service/ivs-realtime`: Updates service API and documentation - `service/kinesisanalyticsv2`: Updates service API and documentation - `service/s3`: Updates service examples - This release makes the default option for S3 on Outposts request signing to use the SigV4A algorithm when using AWS Common Runtime (CRT). ### [`v1.50.37`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15037-2024-03-12) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.36...v1.50.37) \=== ##### Service Client Updates - `service/cloudformation`: Updates service documentation - CloudFormation documentation update for March, 2024 - `service/connect`: Updates service API and documentation - `service/ec2`: Updates service documentation - Documentation updates for Amazon EC2. - `service/kafka`: Updates service API and documentation - `service/ssm`: Updates service documentation - March 2024 doc-only updates for Systems Manager. ### [`v1.50.36`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15036-2024-03-11) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.35...v1.50.36) \=== ##### Service Client Updates - `service/codestar-connections`: Updates service API and documentation - `service/elasticache`: Updates service documentation - Revisions to API text that are now to be carried over to SDK text, changing usages of "SFO" in code examples to "us-west-1", and some other typos. - `service/mediapackagev2`: Updates service API and documentation ### [`v1.50.35`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15035-2024-03-08) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.34...v1.50.35) \=== ##### Service Client Updates - `service/batch`: Updates service API and documentation - This release adds JobStateTimeLimitActions setting to the Job Queue API. It allows you to configure an action Batch can take for a blocking job in front of the queue after the defined period of time. The new parameter applies for ECS, EKS, and FARGATE Job Queues. - `service/bedrock-agent-runtime`: Updates service API and documentation - `service/cloudtrail`: Updates service API and documentation - Added exceptions to CreateTrail, DescribeTrails, and ListImportFailures APIs. - `service/codebuild`: Updates service documentation - This release adds support for a new webhook event: PULL_REQUEST_CLOSED. - `service/cognito-idp`: Updates service API and documentation - `service/guardduty`: Updates service API and documentation - Add RDS Provisioned and Serverless Usage types - `service/transfer`: Updates service API and documentation - Added DES_EDE3\_CBC to the list of supported encryption algorithms for messages sent with an AS2 connector. ### [`v1.50.34`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15034-2024-03-07) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.33...v1.50.34) \=== ##### Service Client Updates - `service/appconfig`: Updates service API and documentation - `service/ec2`: Updates service API and documentation - This release adds an optional parameter to RegisterImage and CopyImage APIs to support tagging AMIs at the time of creation. - `service/grafana`: Updates service API and documentation - `service/lambda`: Updates service documentation - Documentation updates for AWS Lambda - `service/payment-cryptography-data`: Updates service API and documentation - `service/rds`: Updates service API, documentation, waiters, paginators, and examples - Updates Amazon RDS documentation for io2 storage for Multi-AZ DB clusters - `service/snowball`: Updates service documentation - Doc-only update for change to EKS-Anywhere ordering. - `service/wafv2`: Updates service API and documentation - `service/workspaces`: Updates service documentation - Added note for user decoupling ### [`v1.50.33`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15033-2024-03-06) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.32...v1.50.33) \=== ##### Service Client Updates - `service/dynamodb`: Updates service API, documentation, waiters, paginators, and examples - Doc only updates for DynamoDB documentation - `service/imagebuilder`: Updates service API and documentation - `service/mwaa`: Updates service documentation - `service/rds`: Updates service API, documentation, waiters, paginators, and examples - Updated the input of CreateDBCluster and ModifyDBCluster to support setting CA certificates. Updated the output of DescribeDBCluster to show current CA certificate setting value. - `service/redshift`: Updates service documentation - Update for documentation only. Covers port ranges, definition updates for data sharing, and definition updates to cluster-snapshot documentation. - `service/verifiedpermissions`: Updates service API and documentation ### [`v1.50.32`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15032-2024-03-05) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.31...v1.50.32) \=== ##### Service Client Updates - `service/apigateway`: Updates service documentation - Documentation updates for Amazon API Gateway - `service/chatbot`: Updates service API - `service/organizations`: Adds new service - This release contains an endpoint addition - `service/sesv2`: Updates service API and documentation ### [`v1.50.31`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15031-2024-03-04) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.30...v1.50.31) \=== ##### Service Client Updates - `service/cloudformation`: Updates service API and documentation - Add DetailedStatus field to DescribeStackEvents and DescribeStacks APIs - `service/fsx`: Updates service API and documentation - `service/organizations`: Updates service API and documentation - Documentation update for AWS Organizations ### [`v1.50.30`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15030-2024-03-01) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.29...v1.50.30) \=== ##### Service Client Updates - `service/accessanalyzer`: Updates service documentation - `service/autoscaling`: Updates service documentation - With this release, Amazon EC2 Auto Scaling groups, EC2 Fleet, and Spot Fleet improve the default price protection behavior of attribute-based instance type selection of Spot Instances, to consistently select from a wide range of instance types. - `service/ec2`: Updates service documentation - With this release, Amazon EC2 Auto Scaling groups, EC2 Fleet, and Spot Fleet improve the default price protection behavior of attribute-based instance type selection of Spot Instances, to consistently select from a wide range of instance types. ### [`v1.50.29`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15029-2024-02-29) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.28...v1.50.29) \=== ##### Service Client Updates - `service/docdb-elastic`: Updates service API and documentation - `service/eks`: Updates service API - `service/migrationhuborchestrator`: Updates service API and documentation - `service/models.lex.v2`: Updates service API and documentation - `service/quicksight`: Updates service API and documentation - TooltipTarget for Combo chart visuals; ColumnConfiguration limit increase to 2000; Documentation Update - `service/sagemaker`: Updates service API and documentation - Adds support for ModelDataSource in Model Packages to support unzipped models. Adds support to specify SourceUri for models which allows registration of models without mandating a container for hosting. Using SourceUri, customers can decouple the model from hosting information during registration. - `service/securitylake`: Updates service API and documentation ### [`v1.50.28`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15028-2024-02-28) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.27...v1.50.28) \=== ##### Service Client Updates - `service/batch`: Updates service API and documentation - This release adds Batch support for configuration of multicontainer jobs in ECS, Fargate, and EKS. This support is available for all types of jobs, including both array jobs and multi-node parallel jobs. - `service/bedrock-agent-runtime`: Updates service API and documentation - `service/ce`: Updates service API and documentation - `service/ec2`: Updates service API and documentation - This release increases the range of MaxResults for GetNetworkInsightsAccessScopeAnalysisFindings to 1,000. - `service/iot`: Updates service API and documentation - This release reduces the maximum results returned per query invocation from 500 to 100 for the SearchIndex API. This change has no implications as long as the API is invoked until the nextToken is NULL. - `service/wafv2`: Updates service API and documentation </details> <details> <summary>aws/aws-sdk-go-v2 (github.com/aws/aws-sdk-go-v2)</summary> ### [`v1.26.0`](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.25.1...v1.26.0) [Compare Source](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.25.3...v1.26.0) ### [`v1.25.3`](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.25.2...v1.25.3) [Compare Source](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.25.2...v1.25.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> * [chore] [network scraper] Bound flaky test (#31898) For some reason github runners occasionally see 13 instead of 12 metrics See [31001](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31001) * [chore] Updates docker api to version v25 from v24, testcontainers-go from v0.20.0 to v0.29.1 (#31632) **Description:** I don't have permissions to directly add commits to the update PR so running it here - [PR](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31345) - [Issue](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31087) * [fileexporter] Fix wrong marshaler type judgment (#31902) **Description:** Fix wrong marshaler type judgment for `logs` and `metrics` marshaler Signed-off-by: Jared Tan <[email protected]> * [cmd/telemetrygen] Fix logs telemetry attributes key mapping (#31309) **Description:** This PR addresses a bug in the telemetry attribute key mapping for the logs. Previously, the attribute key was incorrectly mapped to the value property, leading to incorrect data representation on the exported logs. **Changes:** Corrected the attribute key mapping logic to ensure the key is mapped to the key, not the value. **Testing:** The changes have been thoroughly tested under various scenarios to ensure the bug has been fixed. --------- Co-authored-by: Pablo Baeyens <[email protected]> * [carbonreceiver]: Do not report fatal error when closed normally (#31913) Signed-off-by: Bogdan Drutu <[email protected]> * [chore][receiver/k8sevent] Enable goleak check (#31917) **Description:** <Describe what has changed.>  Enable goleak check to help ensure no goroutines are being leaked. This is a test only change, a test was missing a shutdown call. **Link to tracking Issue:** <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30438 **Testing:** <Describe what testing was performed and which tests were added.> Existing tests are passing, as well as added goleak check. * [exporter/clickhouse] ClickHouse replication / engine configuration (#31920) ## Originally submitted by @alex1704 in #26599. Their original PR was closed as stale, so I have updated it to the latest branch and made some improvements to code + tests. **Description:** - Add config option for setting `ON CLUSTER` on tables. - Add config option for setting the table `ENGINE`. These changes add the ability to set up [replication for fault tolerance](https://clickhouse.com/docs/en/architecture/replication). **Testing:** Tests for data replication were added to: - `exporter_logs_test.go` (`TestLogsTableCreationOnCluster`) - `exporter_metrics_test.go` (`TestMetricsTablesCreationOnCluster`) - `exporter_traces_test.go` (`TestTracesTablesCreationOnCluster`) Additional tests were added for checking how `TableEngine` is parsed in `config_test.go` (`TestTableEngineConfigParsing`) **Documentation:** Two new fields were added to the config: ```go TableEngine TableEngine `mapstructure:"table_engine"` ClusterName string `mapstructure:"cluster_name"` ``` TableEngine definition ```go type TableEngine struct { Name string `mapstructure:"name"` Params string `mapstructure:"params"` } ``` `table_engine` allows overriding the `ENGINE` in the table creation SQL. Defaults to `MergeTree()`. `ClusterName` allows optionally adding `ON CLUSTER` in the table creation SQL. Disabled by default. Example config for enabling [replication for fault tolerance](https://clickhouse.com/docs/en/architecture/replication): ```yml exporters: clickhouse: endpoint: tcp://127.0.0.1:9000 cluster_name: cluster_1 table_engine: name: ReplicatedMergeTree ``` Link to tracking Issue: Resolves https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24649 * [connector/grafanacloud] add new connector component (#31726) **Description:** This adds a new connector for generating metrics from traces for use in Grafana Cloud. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31647 **Testing:** unit testing **Documentation:** README.md with example configuration. --------- Signed-off-by: Robbie Lankford <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * [connector/datadog] Fix data race (#31921) **Description:** <Describe what has changed.>  Fixes data race issue introduced in the prior PR for container Tags. https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31642 **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> * [chore] lint fixes in cmd/telemetrygen & cmd/opampsupervisor (#31932) **Description:** <Describe what has changed.> - Linting Errors: [https://productionresul…

daixiang0 reviewed Mar 4, 2024

View reviewed changes

pkg/section/local_module.go Outdated Show resolved Hide resolved

petr-korobeinikov force-pushed the localmodule branch from 5e89d5b to a4701e5 Compare March 4, 2024 13:55

petr-korobeinikov force-pushed the localmodule branch from a4701e5 to 7bb14ac Compare March 4, 2024 14:29

petr-korobeinikov requested a review from daixiang0 March 4, 2024 14:31

petr-korobeinikov mentioned this pull request Mar 4, 2024

Cannot run GCI with -s localmodule flag #193

Closed

matthewhughes934 reviewed Mar 6, 2024

View reviewed changes

petr-korobeinikov requested a review from matthewhughes934 March 7, 2024 21:52

petr-korobeinikov force-pushed the localmodule branch from 03fdbc0 to c0778a3 Compare March 8, 2024 07:19

matthewhughes934 reviewed Mar 8, 2024

View reviewed changes

matthewhughes934 approved these changes Mar 8, 2024

View reviewed changes

Enhance LocalModule when no go sources found in project root

0ae02bf

Signed-off-by: Petr Korobeinikov <[email protected]>

petr-korobeinikov force-pushed the localmodule branch from dac2322 to 0ae02bf Compare March 12, 2024 03:56

daixiang0 approved these changes Mar 12, 2024

View reviewed changes

daixiang0 merged commit 4725b0c into daixiang0:master Mar 12, 2024
7 checks passed

petr-korobeinikov deleted the localmodule branch March 12, 2024 06:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance LocalModule when no go sources found in project root #192

Enhance LocalModule when no go sources found in project root #192

petr-korobeinikov commented Mar 2, 2024

daixiang0 commented Mar 4, 2024

petr-korobeinikov commented Mar 4, 2024

daixiang0 commented Mar 5, 2024

matthewhughes934 left a comment

matthewhughes934 Mar 6, 2024

petr-korobeinikov Mar 6, 2024

matthewhughes934 Mar 6, 2024

petr-korobeinikov Mar 6, 2024

daixiang0 Mar 8, 2024

petr-korobeinikov Mar 8, 2024

petr-korobeinikov commented Mar 6, 2024

matthewhughes934 commented Mar 6, 2024 •

edited

Loading

petr-korobeinikov commented Mar 8, 2024

matthewhughes934 left a comment

matthewhughes934 Mar 8, 2024

petr-korobeinikov commented Mar 8, 2024

matthewhughes934 left a comment

CarlosRDomin commented Mar 12, 2024

daixiang0 commented Mar 12, 2024

petr-korobeinikov commented Mar 12, 2024

daixiang0 left a comment

Enhance LocalModule when no go sources found in project root #192

Enhance LocalModule when no go sources found in project root #192

Conversation

petr-korobeinikov commented Mar 2, 2024

daixiang0 commented Mar 4, 2024

petr-korobeinikov commented Mar 4, 2024

daixiang0 commented Mar 5, 2024

matthewhughes934 left a comment

Choose a reason for hiding this comment

matthewhughes934 Mar 6, 2024

Choose a reason for hiding this comment

petr-korobeinikov Mar 6, 2024

Choose a reason for hiding this comment

matthewhughes934 Mar 6, 2024

Choose a reason for hiding this comment

petr-korobeinikov Mar 6, 2024

Choose a reason for hiding this comment

daixiang0 Mar 8, 2024

Choose a reason for hiding this comment

petr-korobeinikov Mar 8, 2024

Choose a reason for hiding this comment

petr-korobeinikov commented Mar 6, 2024

matthewhughes934 commented Mar 6, 2024 • edited Loading

petr-korobeinikov commented Mar 8, 2024

matthewhughes934 left a comment

Choose a reason for hiding this comment

matthewhughes934 Mar 8, 2024

Choose a reason for hiding this comment

petr-korobeinikov commented Mar 8, 2024

matthewhughes934 left a comment

Choose a reason for hiding this comment

CarlosRDomin commented Mar 12, 2024

daixiang0 commented Mar 12, 2024

petr-korobeinikov commented Mar 12, 2024

daixiang0 left a comment

Choose a reason for hiding this comment

matthewhughes934 commented Mar 6, 2024 •

edited

Loading