-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal form change proposal #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for react-daisyui processing.
|
Related to this commit LGTM 👍 |
yoshi6jp
approved these changes
Sep 8, 2023
benjitrosch
approved these changes
Sep 15, 2023
benjitrosch
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit 3c21419.
benjitrosch
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Removes form from modal allowing users to create forms inside modal * Removes form from modal allowing users to create forms inside modal
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's not possible to add a form inside a Modal as it throws this error:
Warning: validateDOMNesting(...): <form> cannot appear as a descendant of <form>.
Clicking on any button inside the modal closes it as well, which is not always intended.
This PR proposes to change this behavior, if a user want to close the modal he can always use:
or
<Button onClick={toggleModal}>Close me</Button>
inside the modal.
This is a proposal change for this opened issue: #415