Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental language change tests #30

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

gautierchomel
Copy link
Collaborator

As discussed during group call, January 16, 2024.
This adds, at the root, one folders named language_change with three files files:

  • test for language change iso 639-1 without country code (i.e. two letters only)
  • test for language change iso 639-1 with country code (i.e. four letters)
  • test for language change iso 639-2 without country code (i.e. three letters)

test for language change iso 639-1 without country code (i.e. two letters only)
test for language change iso 639-1 with country code (i.e. four letters)
test for language change iso 639-2 without country code (i.e. three letters)
@clapierre
Copy link
Collaborator

@gautierchomel
I downloaded your pull request but bringing up these html files in Edge, I am getting the following error messages

This page contains the following errors:
error on line 13 at column 142: Opening and ending tag mismatch: h1 line 13 and h2
Below is a rendering of the page up to the first error.

@gautierchomel gautierchomel marked this pull request as draft January 23, 2024 07:59
@gautierchomel gautierchomel marked this pull request as ready for review January 23, 2024 07:59
@gautierchomel
Copy link
Collaborator Author

@clapierre, strange but true. It's fixed now.

@clapierre
Copy link
Collaborator

Here were the results I found, but I am not an expert here in this.
With
NVDA when I switch to eSpeak NG I get the following results:
(main language code EN / FR): Switches correctly
(Sub language code EN-US / FR-CA): Switches correctly
(3 letter main language code, fra ) : Does not switch languages

NVDA with other voices like Windows OneCore Voices or Microsoft Speech API version 5
Nothing switched, but maybe I need to install additional voices to allow for this.

JAWS with Eloquence all 3 tests pass, all other language options nothing switched correctly. eg. Microsoft Mobile (factory) or SAPI 5x (Factory)

Voice Over on my Mac. I was not able to get any of the 3 to switch I had both English and French set up in voice over and had it to "automatically switch based on language detected.

@avneeshsingh avneeshsingh merged commit 815f908 into daisy:main Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants