-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ace HTTP CLI Dockerfile and .dockerignore #373
base: master
Are you sure you want to change the base?
Conversation
Hello, is |
Hi! Without
With chromium installed using
|
Thank you for the explanation. I am familiar with globally or locally installing Chromium, Firefox etc. "drivers" in some cases with unit tests frameworks, but I incorrectly assumed that Puppeteer pulled-in the correct build of Chromium by default as its peer dependency. I wonder if the |
I tried installing |
In the Dockerfile in this PR, the ace source code is added before installing chromium. That way, when the ace code changes, the latest version of chromium will be installed through apt-get. |
I rabased onto master now. Same behavior. |
Note that Puppeteer v20 switched to Chrome instead of Chromium, but Ace remains on an older version due to other breaking changes that make it impossible to upgrade at this moment in time: |
Let's keep this ace-http Docker PR open for now, but see #392 (comment) for further information about headless Puppeteer vs. Electron |
Added Dockerfile. Fixes #372.
➜ ace git:(dockerfile) docker build . (…) Successfully built 69fe3399436f
➜ ace git:(dockerfile) docker run --network host --rm -it --env ACE_PORT=80 69fe3399436f yarn run v1.22.19 $ /usr/src/ace/node_modules/.bin/ace-http -v 1.2.7-alpha.3 Done in 0.37s. yarn run v1.22.19 $ /usr/src/ace/node_modules/.bin/ace-http -H localhost -p 80 -l en info: [ace-http] server listening on http://localhost:80
➜ ~ curl http://localhost/jobs []%