Fresh Yarn install (yarn.lock update / upgrade) BREAKS NODEJS 6 support #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ists in yarn upgrade (semantic versioning minor updates)
|
PS: yarn |
|
Note that this seems to break Node 6 support. See: |
danielweck
changed the title
…-rf node_modules && rm -rf packages/*/node_modules && rm yarn.lock && yarn install && yarn build && yarn test
|
@rdeltour the TravisCI build now passes https://travis-ci.org/daisy/ace/builds/548530808 |
rdeltour
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
rm -rf node_modules && yarn) ... basically consists inyarn upgrade(semantic versioning minor updates, reflected inyarn.lock)I have been using the latest NPM packages (within the original semver range) for all my builds and tests. So this should be safe to merge :)
Thanks!