Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace version fix #226

Merged
merged 12 commits into from
Apr 30, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.2.1
- export PATH="$HOME/.yarn/bin:$PATH"
script:
- yarn snyk test
# - yarn snyk test
- xvfb-run yarn test --runInBand
branches:
only:
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
<a name="1.0.3"></a>
## [1.0.3](https://github.com/daisy/ace/compare/v1.0.2...v1.0.3) (2019-05-01)
danielweck marked this conversation as resolved.
Show resolved Hide resolved


### Bug Fixes

* Version now reported correctly across the board, see https://github.com/daisy/ace/pull/226



<a name="1.0.2"></a>
## [1.0.2](https://github.com/daisy/ace/compare/v1.0.1...v1.0.2) (2018-05-25)

Expand Down
1 change: 1 addition & 0 deletions packages/ace-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"main": "lib/index.js",
"bin": "bin/ace.js",
"dependencies": {
danielweck marked this conversation as resolved.
Show resolved Hide resolved
"@daisy/ace-config": "^1.0.3",
"@daisy/ace-core": "^1.0.2",
"@daisy/ace-logger": "^1.0.1",
"meow": "^3.7.0",
Expand Down
12 changes: 9 additions & 3 deletions packages/ace-cli/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ const { config, paths } = require('@daisy/ace-config');
const defaults = require('./defaults');
const cliConfig = config.get('cli', defaults.cli);

const pkg = require('@daisy/ace-config/package');

const cli = meow(`
const cli = meow({
help:
`
Usage: ace [options] <input>

Options:
Expand All @@ -31,7 +34,10 @@ const cli = meow(`

Examples
$ ace -o out ~/Documents/book.epub
`, {
`,
// autoVersion: false,
version: pkg.version
}, {
alias: {
f: 'force',
h: 'help',
Expand All @@ -42,7 +48,7 @@ const cli = meow(`
V: 'verbose',
},
boolean: ['force', 'verbose', 'silent', 'subdir'],
string: ['outdir', 'tempdir'],
string: ['outdir', 'tempdir']
});

function sleep(ms) {
Expand Down
2 changes: 1 addition & 1 deletion packages/ace-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@daisy/ace-config",
"version": "1.0.0",
"version": "1.0.3",
"description": "Config utilities for Ace",
"author": {
"name": "DAISY developers",
Expand Down
1 change: 1 addition & 0 deletions packages/ace-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"license": "MIT",
"main": "lib/index.js",
"dependencies": {
"@daisy/ace-config": "^1.0.3",
"@daisy/ace-report": "^1.0.1",
"@daisy/ace-report-axe": "^1.0.1",
"@daisy/epub-utils": "^1.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/ace-core/src/core/ace.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const path = require('path');
const tmp = require('tmp');
const winston = require('winston');
const os = require('os');
const pkg = require('../../package');
const pkg = require('@daisy/ace-config/package');

const EPUB = require('@daisy/epub-utils').EPUB;
const Report = require('@daisy/ace-report').Report;
Expand Down
1 change: 1 addition & 0 deletions packages/ace-http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"main": "lib/index.js",
"bin": "bin/ace-http.js",
"dependencies": {
"@daisy/ace-config": "^1.0.3",
"express": "^4.15.5",
"express-easy-zip": "^1.1.4",
"meow": "^3.7.0",
Expand Down
13 changes: 10 additions & 3 deletions packages/ace-http/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const meow = require('meow');
const ace = require('@daisy/ace-core');
const logger = require('@daisy/ace-logger');

const pkg = require('@daisy/ace-config/package');

const UPLOADS = tmp.dirSync({ unsafeCleanup: true }).name;
const DEFAULTPORT = 8000;
const DEFAULTHOST = "localhost";
Expand All @@ -21,7 +23,9 @@ var upload = multer({dest: UPLOADS});
var joblist = [];
var baseurl = "";

const cli = meow(`
const cli = meow({
help:
`
Usage: ace-http [options]

Options:
Expand All @@ -37,7 +41,10 @@ const cli = meow(`

Examples
$ ace-http -p 3000
`, {
`,
// autoVersion: false,
version: pkg.version
}, {
alias: {
h: 'help',
s: 'silent',
Expand All @@ -47,7 +54,7 @@ const cli = meow(`
p: 'port'
},
boolean: ['verbose', 'silent'],
string: ['host', 'port'],
string: ['host', 'port']
});

function run() {
Expand Down
1 change: 1 addition & 0 deletions packages/ace-report/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"license": "MIT",
danielweck marked this conversation as resolved.
Show resolved Hide resolved
"main": "lib/index.js",
"dependencies": {
"@daisy/ace-config": "^1.0.3",
"escape-html": "^1.0.3",
"fs-extra": "^6.0.1",
"handlebars": "^4.0.11",
Expand Down
2 changes: 1 addition & 1 deletion packages/ace-report/src/report-builders.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

'use strict';

const pkg = require('../package');
const pkg = require('@daisy/ace-config/package');

const { config, paths } = require('@daisy/ace-config');
const defaults = require('./defaults');
Expand Down
2 changes: 1 addition & 1 deletion packages/ace-report/src/report-builders.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const builders = require('./report-builders');
const pkg = require('../package');
const pkg = require('@daisy/ace-config/package');

describe('report builder', () => {
let report;
Expand Down
3 changes: 1 addition & 2 deletions tests/__tests__/cli.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ const path = require('path');
const stripAnsi = require('strip-ansi');

const ace = require('../runAceCLI');
const pkg = require('../../packages/ace-core/package');

const pkg = require('@daisy/ace-config/package');

describe('Running the CLI', () => {
test('with no input should fail', () => {
Expand Down
2 changes: 1 addition & 1 deletion website/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ publishDir = "site"
[params]
description = "**[Ace](/ace)**, an accessibility checker for EPUB! \n\
A **[DAISY Consortium](http://daisy.org)** project. \n\
Latest version: v1.0.2"
Latest version: v1.0.3"
danielweck marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion website/content/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ Ace, the Accessibility Checker for EPUB, is a tool developed by the [DAISY Conso

Read more about the Ace project on [Inclusive Publishing](http://inclusivepublishing.org/ace).

Latest version: v1.0.2.
Latest version: v1.0.3.

Note: We’re working on a simple GUI with an installer, to allow using Ace without having to deal with package managers and command line tools… stay tuned!