fix(outlines): only use headings text content in the outline #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headings extraction script now returns the elements `textContent` property instead of their `innerHTML`. A smarter processing could be devised in a future version: - detect an empty content and report a dummy text - trim long content Fixes #129
rdeltour
force-pushed
the
fix/unstyle-headings-outline
branch
from
2be9d2b to
084fe4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headings extraction script now returns the elements
textContentpropertyinstead of their
innerHTML.A smarter processing could be devised in a future version:
Fixes #129