Fix the detection of epub:type-based page markers + Run script tests in headless Chrome
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rdeltour
commented
Oct 28, 2017
rdeltour
commented
- Introduce a new Jest environment to run tests in headless Chrome (via [Puppeteer](git push --set-upstream origin fix/haspagebreaks))
- Closes page breaks not detected? #85
- introduce a new util module `puppetter-utils` - the mode contains an `addScripts` function to inject script paths to a browser page, annotating the inserted script elements with the `data-ace` attribute. - refactor `checker-chromium` to inject the scripts using this new method. The scripts inserted by Ace are now defined in a single array, easier to read and configure.
The tests for the browser scripts were previously run in a virtual DOM (within Jest’s JDOM environment). This commit introduces a new Jest environment (and companion utils) to run tests in a full browser environment (headless Chrome, driven by Puppeteer). Jest’s mock facility is available in the browser context through the `window.mock` object.
rdeltour
force-pushed
the
fix/haspagebreaks
branch
from
aa6ecd5 to
72e5bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.