Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Ace fails gracefully on SVG Content Documents #94

Closed
rdeltour opened this issue Oct 20, 2017 · 1 comment
Closed

Make sure Ace fails gracefully on SVG Content Documents #94

rdeltour opened this issue Oct 20, 2017 · 1 comment
Assignees
@rdeltour
Labels
enhancement
Milestone
v1.0.0

Comments

@rdeltour
Copy link
Member

Ace doesn't claim to be compatible with SVG Content Documents (at least for v1.0.0). We should at least make sure we fail gracefully.
@rdeltour rdeltour added this to the Beta 3 milestone Oct 20, 2017
@mattgarrish
Copy link

Issuing some message that documents are being skipped would be nice. I tried the sous le vent book from the samples and it runs without any message; the svg are just ignored.

Including a property in the json report that there are svg docs (embedded or in spine) would also be useful as long as they aren't being checked, as I need to indicate that minimum contrast issues still need checking, for example.

@rdeltour rdeltour self-assigned this Dec 5, 2017
rdeltour added a commit that referenced this issue Jan 22, 2018
@rdeltour
feat(data): report the presence of SVG Content Documents
659e189 
When an EPUB has SVG Content Documents, Ace will report them in the
`hasSVGContentDocuments` field of the `properties` section, and will
log a warning saying these documents will be ignored.

Fixes #94.
@rdeltour rdeltour mentioned this issue Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish