Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show source code for violations #82

Closed
SarahMagdalena opened this issue Oct 18, 2017 · 1 comment
Closed

Show source code for violations #82

SarahMagdalena opened this issue Oct 18, 2017 · 1 comment
Assignees
@rdeltour
Labels
enhancement report
Milestone
v0.8.0 “Beta 4”

Comments

@SarahMagdalena
Copy link

Might be good to illustrate failed rules by adding incorrect EPUB source code to the report,
e.g. showing the pointing issue code and sourroundings
@rdeltour rdeltour added this to the Beta 3 milestone Oct 20, 2017
@rdeltour
Copy link
Member

tentatively scheduling this for 1.0.0, but depending on the ease of implementation we may postpone it to after v1.0.0

@rdeltour rdeltour self-assigned this Nov 15, 2017
@rdeltour rdeltour changed the title Extract spine item source code Show source code for violations Nov 15, 2017
@marisademeglio marisademeglio mentioned this issue Dec 4, 2017
Open
rdeltour added a commit that referenced this issue Dec 22, 2017
@rdeltour
feat(report): show source code snippets for violations
df21d2f 
- add a new `html` property to the `earl:result` object
- render the snippet in the "Location" column (only if
  a snippet is available)

Fixes #82
@rdeltour rdeltour mentioned this issue Dec 22, 2017
Merged
rdeltour added a commit that referenced this issue Dec 23, 2017
@rdeltour
feat(report): show source code snippets for violations (#134)
5e053fa 
- add a new `html` property to the `earl:result` object
- render the snippet in the "Location" column (only if
  a snippet is available)

Fixes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
enhancement report
Projects
None yet
Milestone
v0.8.0 “Beta 4”
Development

No branches or pull requests
2 participants
@rdeltour @SarahMagdalena