Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Ace doesn't report DPUB ARIA roles as violations #65

Closed
rdeltour opened this issue Oct 13, 2017 · 5 comments
Closed

Make sure Ace doesn't report DPUB ARIA roles as violations #65

rdeltour opened this issue Oct 13, 2017 · 5 comments

Comments

@rdeltour
Copy link
Member

aXe currently reports DPUB ARIA roles as critical violations (in its aria-roles rule). Ace shouldn't report these as violations.

Possible solutions:

  • override the aria-roles rule with a custom implementation
  • submit a PR to aXe to support DPUB ARIA roles
@JayPanoz
Copy link

Yeah, that would be very useful.

I’ve just tested a complex epub with lots of footnotes, bib ref, etc., and literally wailed in fear and begged to be forgiven when checking the results.

Then I noticed that, 2742 of 2743 violations were about DPUB aria-roles but it was kinda tricky to check the results (I had to parse that first to eliminate those violations).

@rdeltour
Copy link
Member Author

literally wailed in fear and begged to be forgiven when checking the results.

oh, sorry about the cold sweat 😖!

@rdeltour rdeltour self-assigned this Oct 19, 2017
@rdeltour rdeltour added this to the Beta 2 milestone Oct 19, 2017
@JayPanoz
Copy link

Nah don’t worry. Of all the files I could test, I picked the edge case. ;-)

@rdeltour
Copy link
Member Author

Reported in dequelabs/axe-core#580

@LaZay
Copy link

LaZay commented Oct 24, 2017

I have just tested an ePub with ACE Beta version myself.
And I confirm. All DPUB ARIA roles are reported as critical errors, Which is quite ironic as I added these roles on purpose in order to systematically provide ARIA equivalents to epub:type attribute.
https://www.w3.org/TR/dpub-aria-1.0/#roles

rdeltour added a commit that referenced this issue Oct 25, 2017
rdeltour added a commit that referenced this issue Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants