Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a common module for shared constants #63

Closed
rdeltour opened this issue Oct 12, 2017 · 1 comment
Closed

Introduce a common module for shared constants #63

rdeltour opened this issue Oct 12, 2017 · 1 comment
Assignees
@rdeltour
Labels
refactoring
Milestone
v0.7.0 “Beta 3”

Comments

@rdeltour
Copy link
Member

To have easy access to shared info/constants like:

  • the KB base URL
  • the current version number
  • the tool's description (as rendered in the JSON report)
@rdeltour rdeltour added this to the Beta 3 milestone Oct 20, 2017
@rdeltour
Copy link
Member Author

see also #95

@rdeltour rdeltour self-assigned this Nov 15, 2017
rdeltour added a commit that referenced this issue Dec 13, 2017
@rdeltour
feat(config): enable configurability with a config file
8987dd8 
Introduce a new `ace-config` package:
- exposes a `paths` object storing the system paths (log, config, data, etc)
- exposes the config stored in the config file in the `config` object
- exposes constants in the `constants` object

The config file will be stored in the user's OS-specific configuration directory

Fixes #63, Fixes #77
@rdeltour rdeltour mentioned this issue Dec 13, 2017
Merged
rdeltour added a commit that referenced this issue Dec 13, 2017
@rdeltour
feat(config): enable configurability with a config file
f63e1a5 
Introduce a new `ace-config` package:
- exposes a `paths` object storing the system paths (log, config, data, etc)
- exposes the config stored in the config file in the `config` object
- exposes constants in the `constants` object

The config file will be stored in the user's OS-specific configuration directory

Fixes #63, Fixes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
refactoring
Projects
None yet
Milestone
v0.7.0 “Beta 3”
Development

No branches or pull requests
1 participant
@rdeltour