Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessible name of page break markers to come from content? #355

Open
rdeltour opened this issue Jun 17, 2021 · 3 comments
Open

Allow accessible name of page break markers to come from content? #355

rdeltour opened this issue Jun 17, 2021 · 3 comments
Labels

Comments

@rdeltour
Copy link
Member

@clapierre noted in #71 about requiring title or aria-label on page break markers:

I think this may be too strict?
If the author exposes the Page numbers to everyone, there would be no need to require an aria-label as well.

IE: The following should be valid, but currently causes an ACE Serious Issue.

<span epub:type=“pagebreak” role=“doc-pagebreak” id=“page_1”>Page 1</span>
@rdeltour rdeltour added the rules label Jun 17, 2021
@rdeltour
Copy link
Member Author

I think this may be too strict?
If the author exposes the Page numbers to everyone, there would be no need to require an aria-label as well.

Content-provided accessible name is only introduced in DPUB ARIA 1.1. In 1.0, the accessible name could only come from author (i.e. explicit attributes like aria-label). Ace is not be up-to-date with the latest DPUB ARA 1.1 draft.

I'm not sure what's the state of the implementations or how they compute the name. doc-pagebreak inherits from the separator, which itself only allows name from author.

Note also that the KB currently says:

Note that the aria-label is currently required even when the number is visible. A future version of the DPUB-ARIA module is expected to fix this so that the page number is automatically obtained from the content of the element when a label is not specified

And the Accessibility Techniques 1.0 say:

Do not include the page number as text content, as this practice forces the user to hear it announced wherever it occurs (e.g., without any context in the middle of a sentence).

Testing would be welcome to know how Ace should practically report that.

  • If RS+AT compute the accessible name from the content, as allowed in DPUB ARIA 1.1, then Ace should allow that. Maybe with a "best practice" report that this is not ideal for the reasons explained in the techniques (interrupted reading flow).
  • If RS+AT compute the name from author attributes, then Ace should keep on reporting that.

danielweck added a commit that referenced this issue Jul 7, 2022
…e but with textual content inside element (see #355 ) [skip ci]
@danielweck
Copy link
Member

I added unit tests to check this (unchanged behaviour, to be discussed ...): b5d1b66

@danielweck
Copy link
Member

In the Thorium reading system project, there is a discussion about implementing an advanced feature that would "force" the display of normally-hidden page breaks (e.g. via authored CSS, so that they don't visually interfere when inlined or rendered as block inside HTML documents), or page breaks with no explicit text content (i.e. just accessible ARIA label or title attribute).
This is a feature request from screen reader users who struggle to find their place in the document, relative to page breaks (aka page numbers). I find this interesting as screen readers are supposed to report ARIA-labelled page breaks, even if there is no visual explicit text.
edrlab/thorium-reader#1799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants