Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique aria-label / title for landmarks (Invalid Link to KB) #273

Closed
clapierre opened this issue Aug 22, 2019 · 8 comments
Closed

unique aria-label / title for landmarks (Invalid Link to KB) #273

clapierre opened this issue Aug 22, 2019 · 8 comments

Comments

@clapierre
Copy link

Please provide the following details if possible or relevant:

  • [1.1.1] the version of Ace impacted by the issue (as returned by the ace -v command).
  • [10.16.0] the version of Node used to run Ace (as returned by the node -v command).
  • [Mac 10.14] your operating system and version.

Invalid link to KB

The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable
Learn more about: (no specific entry)

@danielweck
Copy link
Member

Evidently, there is no KnowledgeBase entry for this type of reported issue.
Here are the currently-supported entries (do you see a good fit for "The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable"?):

const kbMap = {
'baseUrl': 'http://kb.daisy.org/publishing/',
'map': {
'accesskeys': {url: 'docs/html/accesskeys.html', title: localize("kb.accesskeys")},
'area-alt': {url: 'docs/html/maps.html', title: localize("kb.area-alt")},
'aria-allowed-attr': {url: 'docs/script/aria.html', title: localize("kb.aria-allowed-attr")},
'aria-hidden-body': {url: 'docs/script/aria.html', title: localize("kb.aria-hidden-body")},
'aria-required-attr': {url: 'docs/script/aria.html', title: localize("kb.aria-required-attr")},
'aria-required-children': {url: 'docs/script/aria.html', title: localize("kb.aria-required-children")},
'aria-required-parent': {url: 'docs/script/aria.html', title: localize("kb.aria-required-parent")},
'aria-roles': {url: 'docs/script/aria.html', title: localize("kb.aria-roles")},
'aria-valid-attr-value': {url: 'docs/script/aria.html', title: localize("kb.aria-valid-attr-value")},
'aria-valid-attr': {url: 'docs/script/aria.html', title: localize("kb.aria-valid-attr")},
'button-name': {url: 'docs/html/forms.html', title: localize("kb.button-name")},
'checkboxgroup': {url: 'docs/html/forms.html', title: localize("kb.checkboxgroup")},
'color-contrast': {url: 'docs/css/color.html', title: localize("kb.color-contrast")},
'definition-list': {url: 'docs/html/lists.html', title: localize("kb.definition-list")},
'dlitem': {url: 'docs/html/lists.html', title: localize("kb.dlitem")},
'document-title': {url: 'docs/html/title.html', title: localize("kb.document-title")},
'duplicate-id': {url: 'docs/html/ids.html', title: localize("kb.duplicate-id")},
'empty-heading': {url: 'docs/html/headings.html', title: localize("kb.empty-heading")},
'epub-type-has-matching-role': {url: 'docs/html/roles.html', title: localize("kb.epub-type-has-matching-role")},
'frame-title-unique': {url: 'docs/html/iframes.html', title: localize("kb.frame-title-unique")},
'frame-title': {url: 'docs/html/iframes.html', title: localize("kb.frame-title")},
'heading-order': {url: 'docs/html/headings.html', title: localize("kb.heading-order")},
'href-no-hash': {url: 'docs/html/links.html', title: localize("kb.href-no-hash")},
'html-has-lang': {url: 'docs/html/lang.html', title: localize("kb.html-has-lang")},
'html-lang-valid': {url: 'docs/html/lang.html', title: localize("kb.html-lang-valid")},
'image-alt': {url: 'docs/html/images.html', title: localize("kb.image-alt")},
'image-redundant-alt': {url: 'docs/html/images.html', title: localize("kb.image-redundant-alt")},
'input-image-alt': {url: 'docs/html/images.html', title: localize("kb.input-image-alt")},
'label-title-only': {url: 'docs/html/forms.html', title: localize("kb.label-title-only")},
'label': {url: 'docs/html/forms.html', title: localize("kb.label")},
'layout-table': {url: 'docs/html/tables.html', title: localize("kb.layout-table")},
'link-in-text-block': {url: 'docs/html/links.html', title: localize("kb.link-in-text-block")},
'link-name': {url: 'docs/html/links.html', title: localize("kb.link-name")},
'list': {url: 'docs/html/lists.html', title: localize("kb.list")},
'listitem': {url: 'docs/html/lists.html', title: localize("kb.listitem")},
'meta-refresh': {url: 'docs/html/meta.html', title: localize("kb.meta-refresh")},
'meta-viewport-large': {url: 'docs/html/meta.html', title: localize("kb.meta-viewport-large")},
'meta-viewport': {url: 'docs/html/meta.html', title: localize("kb.meta-viewport")},
'object-alt': {url: 'docs/html/object.html', title: localize("kb.object-alt")},
'p-as-heading': {url: 'docs/html/headings.html', title: localize("kb.p-as-heading")},
'pagebreak-label': {url: 'docs/navigation/pagelist.html', title: localize("kb.pagebreak-label")},
'radiogroup': {url: 'docs/html/forms.html', title: localize("kb.radiogroup")},
'scope-attr-valid': {url: 'docs/html/tables.html', title: localize("kb.scope-attr-valid")},
'server-side-image-map': {url: 'docs/html/maps.html', title: localize("kb.server-side-image-map")},
'table-duplicate-name': {url: 'docs/html/tables.html', title: localize("kb.table-duplicate-name")},
'table-fake-caption': {url: 'docs/html/tables.html', title: localize("kb.table-fake-caption")},
'td-has-header': {url: 'docs/html/tables.html', title: localize("kb.td-has-header")},
'td-headers-attr': {url: 'docs/html/tables.html', title: localize("kb.td-headers-attr")},
'th-has-data-cells': {url: 'docs/html/tables.html', title: localize("kb.th-has-data-cells")},
'valid-lang': {url: 'docs/html/lang.html', title: localize("kb.valid-lang")},
'video-caption': {url: 'docs/html/video.html', title: localize("kb.video-caption")},
'video-description': {url: 'docs/html/video.html', title: localize("kb.video-description")},
}
};

@danielweck
Copy link
Member

Maybe docs/script/aria.html https://kb.daisy.org/publishing/docs/script/aria.html ?

@danielweck
Copy link
Member

danielweck commented Aug 29, 2019

The message "The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable" comes from the landmark-is-unique check:

https://github.com/dequelabs/axe-core/blob/master/lib/checks/landmarks/landmark-is-unique.json

@danielweck
Copy link
Member

I created a Pull Request (to be reviewed):
#279

@danielweck
Copy link
Member

Charles, could you please share the EPUB so we can reproduce the exact Axe check/rule at our end? Thank you!

@clapierre
Copy link
Author

@danielweck I will check with the publisher and send you the EPUB directly once they approve.
Thanks

@laudrain
Copy link

@danielweck yes it comes from the rules of uniqueness of landmarks, but as I stated in issue 271, I cannot find any exhaustive list of landmark roles !

@danielweck
Copy link
Member

Fixed via #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants