Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped characters in HTML report #161

Closed
clapierre opened this issue Jan 23, 2018 · 12 comments
Closed

Escaped characters in HTML report #161

clapierre opened this issue Jan 23, 2018 · 12 comments
Assignees
Labels
Milestone

Comments

@clapierre
Copy link

RC1

serious | EPUB | metadata-schema-accessibilitysummaryAce | "undefined"OEBPS/package.opf
-- | -- | -- | -- | Add a 'schema:accessibilitySummary' metadata property to the Package Document

@clapierre
Copy link
Author

Also what is "undefined" in Location mean?

@rdeltour
Copy link
Member

@clapierre, I'm not sure I understand the issue. Paste error maybe? Can you please elaborate or send an input file?

Also, "undefined" in the location column means that the document’s title is missing.

@rdeltour rdeltour added this to the v1.0.0 milestone Jan 23, 2018
@clapierre
Copy link
Author

aww sorry the GitHub comment converted it correctly
this is what we see in the HTML Report (adding extra space so it shows here

Add a & #39;schema:accessibilitySummary& #39; metadata property to the Package Document

@rdeltour
Copy link
Member

@marisademeglio can you look into that? I suspect it is in the HTML report generation…

@marisademeglio
Copy link
Member

@clapierre @rdeltour yes there was a problem with those characters appearing so I fixed that recently, but maybe the fix causing new issues. I'm guessing you haven't seen this behavior before in previous releases? Do you think you could send me an input file?

@clapierre
Copy link
Author

Should be very easy to reproduce as all EPUBs currently do not have an accessibilitySummary right?
If it is some weird combination that may only appear with a certain combo of errors/warnings I am happy to share the file. Let me know if it is needed.

@clapierre
Copy link
Author

I didn't notice this before, but this error also occurred in 0.9.0, however in 0.3 it behaved correctly.
Sorry I don't have anything in-between.

@rdeltour
Copy link
Member

the quotes render fine for me, tested on Safari 11.0.3, Firefox 58.0 and Chrome 63.0.

Can you please share your OS+browser versions, and maybe send a sample report? (to see if the report’s content is indeed different from what I get).

@clapierre
Copy link
Author

Ok, so it seems to happen intermittently in Safari and Chrome. I haven't been able to reproduce the issue in FF.
In Safari I see the escape characters 90% of the time then it works correctly on a reload, but not always.

I guess chalk this up to browser and timing issues. there are over 102 pages of errors and warnings for this EPUB which may be part of the reason why this is occasionally happening.

@clapierre
Copy link
Author

BTW Safari was 11.0.2, and Chrome is 63.0.3239.132 (Official Build) (64-bit), FF 58.0

@rdeltour
Copy link
Member

This is apparently an edge case due to the large file of the report.

I'm moving this out of the 1.0 milestone until we can further investigate. We’ll try to fix that in a dot release.

Charles, can you send us the report file?

@rdeltour rdeltour removed this from the v1.0.0 milestone Jan 26, 2018
@marisademeglio
Copy link
Member

I can reproduce it consistently if I open the report and then apply filters to the table using the dropdowns. The escape characters then show up, whereas they didn't initially.

However, I am not sure why this is happening. The initial vs filtered table views are populated from the same source data. The data is initially escape()'d because otherwise the whole webpage halts when it reaches a description about a "Missing < title > element", and so escaping takes care of the angle brackets. I've tried both unescaping the data and not unescaping the data, neither of which seems to have an effect on the behavior reported here.

marisademeglio added a commit that referenced this issue Apr 19, 2018
The report includes dcterms:conformsTo in the metadata table and reports it as missing if it is not present.

The report also shows HTML entities correctly.

Some report helper functions have more consistent naming too.

Fixes #161
Fixes #171
@rdeltour rdeltour added this to the v1.0.1 milestone May 25, 2018
rdeltour pushed a commit that referenced this issue May 25, 2018
The report includes dcterms:conformsTo in the metadata table and reports it as missing if it is not present.

The report also shows HTML entities correctly.

Some report helper functions have more consistent naming too.

Fixes #161
Fixes #171
rdeltour pushed a commit that referenced this issue May 25, 2018
The report includes dcterms:conformsTo in the metadata table and reports it as missing if it is not present.

The report also shows HTML entities correctly.

Some report helper functions have more consistent naming too.

Fixes #161
Fixes #171
rdeltour pushed a commit that referenced this issue May 25, 2018
The report includes dcterms:conformsTo in the metadata table and reports it as missing if it is not present.

The report also shows HTML entities correctly.

Some report helper functions have more consistent naming too.

Fixes #161
Fixes #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants