Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unjustified dlitem error #114

Closed
tofi86 opened this issue Nov 14, 2017 · 3 comments
Closed

unjustified dlitem error #114

tofi86 opened this issue Nov 14, 2017 · 3 comments
Assignees

Comments

@tofi86
Copy link

tofi86 commented Nov 14, 2017

Imapct Rule Location Detail
serious dlitem kapitel5.xhtml#epubcfi(/4/14[liste_definition1]/2/2) Description list item does not have a <dl> parent elementLearn more about Lists
serious dlitem kapitel5.xhtml#epubcfi(/4/14[liste_definition1]/2/4) Description list item does not have a <dl> parent elementLearn more about Lists

and this is my HTML content:

<div class="liste_definition typ1 lastInContainer" id="liste_definition1">
	<dl>
		<dt>Biber</dt>
		<dd>(Castoridae) sind höhere Säugetiere (Eutheria) und gehören zur Ordnung der Nagetiere (Rodentia).</dd>
	</dl>
</div>

Besides the missing but optional <def> element I have no clue why this HTML content is not valid.

@marisademeglio
Copy link
Member

Interesting, looks like aXe (the underlying engine used by Ace to analyze HTML documents) reports this error when the file extension is .xhtml but when it's .html, it reports no errors. See attached for identical samples (except for the extension).
test-dl.zip

@mattgarrish
Copy link

Yes, this a known issue. Romain and I have opened issues around xhtml handling in axe. Romain was going to talk with them last week about support, so hopefully he'll have some positive news. It's a problem with element name matching when namespaces are involved.

@rdeltour
Copy link
Member

Romain was going to talk with them last week about support, so hopefully he'll have some positive news

Wilco and I talked about the pending PRs, including support for DPUB ARIA roles, but we didn't tackle that one (filed in aXe as dequelabs/axe-core#581).

I'll have a look at how to fix this; we need a patch for Ace in any case.

@rdeltour rdeltour added this to the v0.7.0 “Beta 3” milestone Nov 15, 2017
@rdeltour rdeltour self-assigned this Nov 15, 2017
@rdeltour rdeltour mentioned this issue Nov 20, 2017
rdeltour added a commit that referenced this issue Dec 13, 2017
aXe v2.x uses an equality check based on the uppercase `tagName`
property, but this latter is case-sensitive in XHTML.

This change patches aXe until a PR is submitted to fix dequelabs/axe-core#581

Fixes #114
rdeltour added a commit that referenced this issue Dec 13, 2017
aXe v2.x uses an equality check based on the uppercase `tagName`
property, but this latter is case-sensitive in XHTML.

This change patches aXe until a PR is submitted to fix dequelabs/axe-core#581

Fixes #114
rdeltour added a commit that referenced this issue Jan 10, 2018
aXe 2.6.x fixes a couple issues that make a couple monkey patches
obsolete:

- issue with `getSelector` on XHTML (see #57)
- issue with `dl` content model (see #114)
rdeltour added a commit that referenced this issue Jan 18, 2018
aXe 2.6.x fixes a couple issues that make a couple monkey patches
obsolete:

- issue with `getSelector` on XHTML (see #57)
- issue with `dl` content model (see #114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants