Knowledge Base integration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link to online web), also fixed Electron browser window issues (lifecycle). Note: HTTPS secure server with self-signed certificate
|
Draft release "Ace for desktop v1.0.0-beta.2" Windows and MacOS installers are 140MB each (currently uploading). |
rdeltour
approved these changes
May 1, 2019
| } | ||
| }, | ||
| { | ||
| label: 'Web (online)', |
There was a problem hiding this comment.
I'm not sure we'll eventually want to keep this option; we'll likely prefer something more transparent like an auto-updater. But this can definitely be removed later after the beta; having both in the beta makes sense.
|
Thank you Romain, I am going to merge this PR into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is based on officially-released Ace core packages (
@daisy/ace-xxx), which do not include the Axe update for localization (there is a separate PR for that ( #40 ), which depends on unreleased Ace core packages , and which will be released separately once the Axe-related "regressions" are addressed)