Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate Violation error Best Practice - unique desc id #136

Closed
Amkiram opened this issue Apr 2, 2021 · 4 comments
Closed

Moderate Violation error Best Practice - unique desc id #136

Amkiram opened this issue Apr 2, 2021 · 4 comments

Comments

@Amkiram
Copy link

Amkiram commented Apr 2, 2021

I have just created an EPUB that passes the EPUB checker inside calibre with flying colours, and all of the Ace by Daisy checks, except for flagging this one Moderate Best Practice issue:

Moderate Best Practice landmark-uniqueVia: aXe FixedRevisedLilli-3.xhtml#epubcfi(/4[FixedRevisedLilli-3]/6[_idContainer007]/4[desc002])

Titelsida: akvarellmålning av en blå fjällräv på en stig i skenet av norrsken.

bild på förlagets logotyp, "NDIO" med stora, röda bokstäver på svart och vit bakgrund, "kultur och kommunikation" i små vita bokstäver på röd bakgrund under.

Originally, I figured that the issue was that I titled it "002b", so instead I changed it to a later desc, "024". The issue remained, so I went through the EPUB, first to last xhtml page, and changed all the descs to run in chronological order as they appear in the EPUB, from 001-027. But Ace is STILL flagging this as a fault, on this page only for some reason. There's nothing different about my code here, I have checked and checked. Is this just a bug, or am I doing something wrong? This is my structure on that page, which is returning the "Moderate" Best Practice warning from Ace:

<div id="_idContainer007"> <img class="_idGenObjectAttribute-1 _idGenObjectAttribute-2" src="image/Nr2NorrskensravTitelsida.jpg" alt="illustration" aria-describedby="desc002" /> <aside class="fig-desc" id="desc002"> <p>Titelsida: akvarellmålning av en blå fjällräv på en stig i skenet av norrsken. </p> </aside> </div> <div id="_idContainer008"> <img class="_idGenObjectAttribute-1 _idGenObjectAttribute-2" src="image/logga_kvalitet_tryck.jpg" alt="illustration" aria-describedby="desc003" /> <aside class="fig-desc" id="desc003"> <p>bild på förlagets logotyp, "NDIO" med stora, röda bokstäver på svart och vit bakgrund, "kultur och kommunikation" i små vita bokstäver på röd bakgrund under. </p> </aside> </div>

@danielweck
Copy link
Member

landmark-unique should be fixed in Ace "next":
daisy/ace#314
Could you please share an EPUB to test with? Many thanks!

@Amkiram
Copy link
Author

Amkiram commented Apr 8, 2021 via email

@danielweck
Copy link
Member

Ah, good to hear you found a workaround. Daisy Ace uses Deque Axe behind the scenes to perform accessibility checks in each individual HTML publication document. Some validation rules depend on the visibility of elements in the page, so perhaps that is the reason for the reported warnings?

@Amkiram
Copy link
Author

Amkiram commented Apr 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants