Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Support Node 12 #36

Closed
megastef opened this issue Apr 26, 2019 · 1 comment
Closed

Support Node 12 #36

megastef opened this issue Apr 26, 2019 · 1 comment

Comments

@megastef
Copy link
Contributor

Please add support for Node 12. My Travis test fails.
On my dev machine, I updated node-pre-gyp to [email protected] and then gc-stats was compiled.
@megastef
Copy link
Contributor Author

I made PR #37 - please check if everything is OK. I think updating node-pre-gyp should solve the installation problem on node 12.

dainis added a commit that referenced this issue May 4, 2019
@dainis
#36 update nan so that it compiles on node 12
97fd32d
@dainis dainis closed this as completed May 13, 2019
@yvasiyarov yvasiyarov mentioned this issue May 22, 2019
Closed
kumarrishav pushed a commit to kumarrishav/node-gcstats that referenced this issue Dec 4, 2020
@dainis
dainis#36 update nan so that it compiles on node 12
cd1144a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dainis @megastef