Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception of Overlapping files thrown while compacting throw away all work done by that compaction #94

Open
pcmind opened this issue Jan 3, 2018 · 0 comments

Comments

@pcmind
Copy link
Contributor

pcmind commented Jan 3, 2018

Exception thrown while doing compaction will result in discarding compaction result. This exception is not as rare as one may like and result in losing costly compaction work (CPU/IO).

Detecting (computing) correctly overlapping files while compacting mem tables would avoid completely this exception and work been thrown away.

The frequency of this exception is related with the key set, order and speed in with they are inserted/deleted.

Removing exception handling done at DbImpl#L1214 and running the build, will most of the time result into some failed unit tests.

pcmind added a commit to pcmind/leveldb that referenced this issue Jan 3, 2018
pcmind added a commit to pcmind/leveldb that referenced this issue Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant