-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clear expired gifted plus subscription #2604
base: main
Are you sure you want to change the base?
Conversation
ilasw
commented
Jan 18, 2025
- add new cron for cleaning expired gifted plus subscription;
- add test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things missed, overall looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing besides Ante's comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, but good to go after that.
.createQueryBuilder('user') | ||
.update() | ||
.set({ subscriptionFlags: {} }) | ||
.where('"user"."subscriptionFlags" ->> \'giftExpirationDate\' < :time', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.where('"user"."subscriptionFlags" ->> \'giftExpirationDate\' < :time', { | |
.where(`"user"."subscriptionFlags"->>'giftExpirationDate' < :time`, { |
Co-authored-by: Ante Barić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing besides Ante's comment.