Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit custom feed view from date #2557

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Dec 19, 2024

AS-874

also not removing default custom feed if not plus

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the accidental push, other than that it looks amazing 🚀

.infra/Pulumi.adhoc.yaml Outdated Show resolved Hide resolved
@@ -510,6 +510,7 @@ const loggedInBoot = async ({
language: user.language || undefined,
image: mapCloudinaryUrl(user.image),
cover: mapCloudinaryUrl(user.cover),
defaultFeedId: isPlus ? user.defaultFeedId : null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return the my-feed id (userId) or basically wouldn't really matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is default when you don't have anything set, frontend expects it as well

@capJavert capJavert merged commit c23c51e into main Dec 20, 2024
8 checks passed
@capJavert capJavert deleted the custom-feeds-view-date branch December 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants