New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NUMERIC NOT NULL #60

Merged

daichirata merged 2 commits into daichirata:master from sonatard:numeric

Jun 18, 2024

Contributor

sonatard commented Jun 17, 2024 •

edited

Loading

Fix #59

$ hammer diff spanner://projects/xxx/instances/yyy/databases/zzz schema.sql
ALTER TABLE Test ADD COLUMN A NUMERIC NOT NULL DEFAULT (0);
ALTER TABLE Test ALTER COLUMN A DROP DEFAULT;

Since spansql.NumericLiteral type does not exist in https://github.com/googleapis/google-cloud-go, I am using FloatLiteral instead.

sonatard added 2 commits

June 17, 2024 13:50


          Fix NUMERIC NOT NULL


          Add NUMERIC Type Default tests

2b1a21c

daichirata merged commit fb333c3 into daichirata:master

6 checks passed

Owner

daichirata commented Jun 18, 2024

Thanks for the PR!

sonatard deleted the numeric branch

June 18, 2024 02:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet