Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pnpm cache #883

Merged
merged 8 commits into from
Sep 16, 2024
Merged

ci: pnpm cache #883

merged 8 commits into from
Sep 16, 2024

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Sep 15, 2024

3mins -> 37s

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Sep 16, 2024 8:57pm

@himself65 himself65 marked this pull request as ready for review September 15, 2024 08:48
Copy link

codesandbox-ci bot commented Sep 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

# Conflicts:
#	.github/actions/playwright/action.yml
@dai-shi
Copy link
Owner

dai-shi commented Sep 16, 2024

🎉

@dai-shi dai-shi merged commit e016580 into dai-shi:main Sep 16, 2024
28 checks passed
@himself65 himself65 deleted the pnpm branch September 16, 2024 23:07
@dai-shi
Copy link
Owner

dai-shi commented Oct 9, 2024

@himself65 It seems like the cache only works for ubuntu, and for macos and windows, ci installs playwright every time, saying it doesn't find a cache.

https://github.com/dai-shi/waku/actions/runs/11258656376/job/31305801590?pr=958

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants