Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load module for actions #841

Merged
merged 3 commits into from
Aug 20, 2024
Merged

fix: load module for actions #841

merged 3 commits into from
Aug 20, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Aug 20, 2024

oh, boy, this is huge.

There must be huge room for improvement with vite-plugin-rsc-rsdw.ts. We should never use import on the server in PRD.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Aug 20, 2024 3:36am

Copy link

codesandbox-ci bot commented Aug 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review August 20, 2024 03:44
@dai-shi dai-shi merged commit 036559f into main Aug 20, 2024
28 checks passed
@dai-shi dai-shi deleted the fix/load-action-module branch August 20, 2024 04:30
dai-shi added a commit that referenced this pull request Aug 21, 2024
While working on #841, I noticed it's a valid hack for now. So,
simplified a little bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant