Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eliminate workerd condition #764

Merged
merged 1 commit into from
Jun 30, 2024
Merged

chore: eliminate workerd condition #764

merged 1 commit into from
Jun 30, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jun 30, 2024

This workerd condition was originally required for the worker thread (not because of the worker thread, but of server.edge), and for consistency, the same config existed in build.ts.
Now, as we removed the worker thread in #762, I'm confident of removing it too.

cc @himself65

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jun 30, 2024 6:15am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review June 30, 2024 06:25
@dai-shi dai-shi merged commit c4589ce into main Jun 30, 2024
28 checks passed
@dai-shi dai-shi deleted the eliminate-workerd branch June 30, 2024 10:22
dai-shi added a commit that referenced this pull request Jul 1, 2024
Not exactly sure which PR made it possible. #762 or #764? or?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant