Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 1 tutorial #650

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Chapter 1 tutorial #650

merged 5 commits into from
Apr 16, 2024

Conversation

dizzyjaguar
Copy link
Contributor

@dizzyjaguar dizzyjaguar commented Apr 5, 2024

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2024 10:58pm

Copy link

codesandbox-ci bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the file to docs/tutorials/getting-started.mdx

@dai-shi
Copy link
Owner

dai-shi commented Apr 5, 2024

@sandren any feedback?

@sandren
Copy link
Collaborator

sandren commented Apr 8, 2024

Thanks for working on this.

It's ok that it's still a work-in-progress, but we shouldn't merge any placeholder content. I notice a few pieces:

  • (?possibly insert image here?)
  • (insert a good example here)
  • They will be...
  • Insert Link To Next Chapter

It would be better to highlight what you can do in the client components section (instead of saying what you cannot do in server components). That will help balance those two sections as well.

Also I understand the routing section is scoped to what's present in the default starter, but it should still cover dynamic rendering, segment routes, etc.

Thanks! 🙂

@dizzyjaguar
Copy link
Contributor Author

dizzyjaguar commented Apr 8, 2024

@sandren That all sounds good!

  • I'll get those placeholders removed
  • Great idea to balance the RSC and Client Components
  • For the rest of the routing I was planning to go over those details in Chapter 2 when the user builds the todo app; since then we will have some more situations to use them. Do you think I should I still attempt to go over those features in Chapter 1 as-well?

Thanks for reviewing 🙏🏼
Should hopefully have these changes pushed in the next few days.

@sandren
Copy link
Collaborator

sandren commented Apr 8, 2024

  • For the rest of the routing I was planning to go over those details in Chapter 2 when the user builds the todo app; since then we will have some more situations to use them.

That's fine as long as the language of Chapter 1 doesn't imply that single-routes are all that are available. It should be clear that it's only covering those for now because that's what's present in the starter. 🙂

@dizzyjaguar
Copy link
Contributor Author

dizzyjaguar commented Apr 8, 2024

  • For the rest of the routing I was planning to go over those details in Chapter 2 when the user builds the todo app; since then we will have some more situations to use them.

That's fine as long as the language of Chapter 1 doesn't imply that single-routes are all that are available. It should be clear that it's only covering those for now because that's what's present in the starter. 🙂

Awesome, I'll add something in that section about going over the rest of the routing in the next chapter! 😎

@dizzyjaguar
Copy link
Contributor Author

@dai-shi @sandren

Just pushed those small updates 🙂

Let me know if theres anything else!~

@dai-shi dai-shi requested a review from sandren April 13, 2024 23:44
Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few small revisions, but otherwise everything looks good to me. Thanks @dizzyjaguar! 🙂

@dizzyjaguar
Copy link
Contributor Author

@sandren Awesome! 🎆
@dai-shi & @sandren should I start working on Chapter 2 after this gets merged in?

@dai-shi
Copy link
Owner

dai-shi commented Apr 16, 2024

Yeah!

@dai-shi dai-shi merged commit 82be450 into dai-shi:main Apr 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants