Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): unstable_redirect #593

Merged
merged 9 commits into from
Mar 12, 2024
Merged

feat(router): unstable_redirect #593

merged 9 commits into from
Mar 12, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 11, 2024

rerender is from waku/server.
redirect is from waku/router/server.

It's confusing because input and pathname look similar with current router implementation, but it might be very different in the future.

  • expose unstable_redirect
  • accept skip
  • refactor should-skip
  • change location

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 12, 2024 3:46am

Copy link

codesandbox-ci bot commented Mar 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Mar 11, 2024
83 tasks
@dai-shi dai-shi merged commit 1fc717f into main Mar 12, 2024
28 checks passed
@dai-shi dai-shi deleted the feat/redirect branch March 12, 2024 07:16
@dai-shi dai-shi mentioned this pull request Mar 18, 2024
dai-shi added a commit that referenced this pull request Mar 18, 2024
it's a regression in #593.
dai-shi added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant