Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fs-router for non-Node envs #575

Merged
merged 9 commits into from
Mar 7, 2024
Merged

fix: fs-router for non-Node envs #575

merged 9 commits into from
Mar 7, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 7, 2024

#572 depends on Node.js even in production build, which isn't ideal.

  • persist build config in entries
  • fix defineRouter
  • fix createPages
  • fix fsRouter

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 7, 2024 3:29pm

Copy link

codesandbox-ci bot commented Mar 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Mar 7, 2024
83 tasks
@dai-shi
Copy link
Owner Author

dai-shi commented Mar 7, 2024

That was a huge misunderstanding of mine. The approach I did for the full day doesn't work. Let me start over. 😓 😓 😓

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 7, 2024

Hmm, maybe not fully wrong, but I wonder if the current approach is ideal. Well, I've been going back and forth and it will happen again...

@dai-shi dai-shi marked this pull request as ready for review March 7, 2024 15:28
@dai-shi dai-shi merged commit 2852bd1 into main Mar 7, 2024
28 checks passed
@dai-shi dai-shi deleted the fix/fs-router branch March 7, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant