-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support custom 404 (static html only) #497
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@aheissenberger Can you work on AWS Lambada? If this PR is still open, send a PR to this branch, otherwise to |
examples/01_template/public/404.html
Outdated
@@ -0,0 +1 @@ | |||
<h1>Custom Not Found Page</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I want use javascript here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a manual setup not related to Waku itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it like a static image asset file. Up until now, it's very hard coded. So, this at least makes it configurable. And, it works without SSR.
I plan to do full customization in #329. But, if we want a solution "with React" we need another solution. I'll think about it, but it requires SSR.
A question for you: How should we deal with customizing 404 without SSR? What's the typical way with Vite + React SPA?
not related to Waku itself
Yeah, it's not related to RSC. But, we need do something and this is a minimal setup.
…olution for 404 in the future.
Jut put
./public/404.html
.