Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom 404 (static html only) #497

Merged
merged 11 commits into from
Feb 19, 2024
Merged

support custom 404 (static html only) #497

merged 11 commits into from
Feb 19, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Feb 17, 2024

Jut put ./public/404.html.

Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Feb 19, 2024 9:46am

@dai-shi dai-shi mentioned this pull request Feb 17, 2024
87 tasks
Copy link

codesandbox-ci bot commented Feb 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner Author

dai-shi commented Feb 18, 2024

@aheissenberger Can you work on AWS Lambada?
@threepointone Can you work on Partykit?

If this PR is still open, send a PR to this branch, otherwise to main.

@@ -0,0 +1 @@
<h1>Custom Not Found Page</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I want use javascript here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a manual setup not related to Waku itself

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it like a static image asset file. Up until now, it's very hard coded. So, this at least makes it configurable. And, it works without SSR.

I plan to do full customization in #329. But, if we want a solution "with React" we need another solution. I'll think about it, but it requires SSR.

A question for you: How should we deal with customizing 404 without SSR? What's the typical way with Vite + React SPA?

not related to Waku itself

Yeah, it's not related to RSC. But, we need do something and this is a minimal setup.

@dai-shi dai-shi changed the title support custom 404 support custom 404 (static html only) Feb 19, 2024
@dai-shi dai-shi merged commit 18e5631 into main Feb 19, 2024
28 checks passed
@dai-shi dai-shi deleted the custom-404 branch February 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants