Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Example / SSR Target selection based deployment target #481

Conversation

aheissenberger
Copy link
Contributor

An Example to detect broken selection of the server side modules from external packages.
Should help to fix #478

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 3:57pm

Copy link

codesandbox-ci bot commented Feb 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit efdedd2:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.
I would like to avoid adding examples for now. Some of examples are showcases and others are for development. I want to reduce the number of them.

Can you turn this into e2e/fixtures/lib-compat or something and add e2e spec?
fixtures should be very minimal.

@aheissenberger
Copy link
Contributor Author

Thanks for working on this. I would like to avoid adding examples for now. Some of examples are showcases and others are for development. I want to reduce the number of them.

Can you turn this into e2e/fixtures/lib-compat or something and add e2e spec? fixtures should be very minimal.

I will convert it in a fixture and replace the screenshot with specific test checks

@aheissenberger
Copy link
Contributor Author

replaced by #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: document is not defined / SSR Production Build / wrong target
2 participants