Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: no index html #289

Merged
merged 36 commits into from
Dec 19, 2023
Merged

breaking: no index html #289

merged 36 commits into from
Dec 19, 2023

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 18, 2023

  • examples
  • website
  • fixtures

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 19, 2023 6:57am

Copy link

codesandbox-ci bot commented Dec 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f48130f:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@dai-shi dai-shi mentioned this pull request Dec 18, 2023
83 tasks
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for localhost:62143..62143 stderr:  WebSocket server error: Port is already in use

62143 stdout:  ready: Listening on http://localhost:62143/

62143 stderr:  (!) Could not auto-determine entry point from rollupOptions or html files and there are no explicit optimizeDeps.include patterns. Skipping dependency pre-bundling.

.
Connected!
debug: [vite] connecting...
debug: [vite] connected.
info: %cDownload the React DevTools for a better development experience: https://reactjs.org/link/react-devtools font-weight:bold
62143 stdout:  11:01:21 PM [vite] ✨ new dependencies optimized: react-dom

62143 stdout:  11:01:21 PM [vite] ✨ optimized dependencies changed. reloading

info: %cDownload the React DevTools for a better development experience: https://reactjs.org/link/react-devtools font-weight:bold
error: Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
error: Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
error: Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
error: Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
error: The above error occurred in the <Counter> component:

    at Counter (http://localhost:62143/@fs/C:/Users/himse/Code/waku/examples/11_form/src/components/Counter.tsx:30:3)
    at div
    at Slot (http://localhost:62143/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:85:24)
    at Root (http://localhost:62143/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:65:24)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.
  x  1 [chromium] › examples-smoke.spec.ts:173:9 › smoke test on 11_form: dev › check title (6.0s)
Waiting for localhost:62163..62163 stderr:  WebSocket server error: Port is already in use

@dai-shi dai-shi merged commit 7c0a6ef into main Dec 19, 2023
9 checks passed
@dai-shi dai-shi deleted the breaking/no-index-html branch December 19, 2023 10:25
Comment on lines +3 to +4
// XXX I don't know why/how this works
import '../style.css';
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for production (= npm run website:prd),
but it's very flaky in development (npm run website:dev).
Can anyone help investigating what's the right way in vite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants