fix(router): fallback support in new_defineRouter and new_createPages #1013
+66
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
reviewed
Nov 24, 2024
| }>; | ||
| }): ReturnType<typeof defineEntries> { | ||
| const platformObject = unstable_getPlatformObject(); | ||
| type MyPathConfig = { | ||
| pattern: string; | ||
| pathname: PathSpec; | ||
| // FIXME Do we need this isStaticRouteElement? |
There was a problem hiding this comment.
nope! good catch, safe to remove. This just slipped in as left over
dai-shi
commented
Nov 25, 2024
Comment on lines
+317
to
+322
| // HACK I'm not sure if this is the right way | ||
| return createElement( | ||
| ChildrenContextProvider, | ||
| { value: createElement(InnerErr, { err }) }, | ||
| fallback, | ||
| ); |
There was a problem hiding this comment.
I wonder if this hack works for new_createPages fallback. Let check it after merging...
There was a problem hiding this comment.
It doesn't work. so #1015.
dai-shi
commented
Nov 25, 2024
Comment on lines
+334
to
+339
| if (unstable_renderPrev) { | ||
| if (!elementsPromise.prev) { | ||
| throw new Error('Missing prev elements'); | ||
| } | ||
| return renderSlot(elementsPromise.prev); | ||
| } |
There was a problem hiding this comment.
I'm not happy with this, and hope to redesign it after finishing our current transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fallback mechanism for #1003.