Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query string should be passed through URLSearchParams #1004

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

tylersayshi
Copy link
Contributor

@tylersayshi tylersayshi commented Nov 16, 2024

maybe this is not the right way to fix the issue, but this does change the query params to be available on the server which was missing before.

needs to come after #1000

this PR should just be for 13a3178 once 1000 is merged

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 11:54pm

Copy link

codesandbox-ci bot commented Nov 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/waku/src/router/define-router.ts Show resolved Hide resolved
@dai-shi dai-shi merged commit bf4fe71 into dai-shi:main Nov 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants