unexpected cached result

[himself65]

export default defineRouter(
  async id => {
    switch (id) {
      case 'index': {
        const { default: AppCreator } = await import('./src/app.js');
        return AppCreator({
          name: 'this is index'
        });
      }
      case 'about': {
        const { default: AppCreator } = await import('./src/app.js');
        return AppCreator({
          name: 'this is about'
        });
      }
      default:
        return null;
    }
  },
  async () => {
    return ['index', 'about'];
  }
);

const App = ({ name = "Anonymous" }) => () => {
  return (
    <div style={{ border: "3px red dashed", margin: "1em", padding: "1em" }}>
      <h1>Hello {name}!!</h1>
      <h3>This is a server component.</h3>
    </div>
  );
};

export default App;

[dai-shi]

Hmm? I don't know how it's happening...
I can investigate it later. A full reproduction might be helpful.

[himself65]

https://github.com/himself65/affine-waku/blob/issue-cached

[dai-shi]

Thanks! I know what's happening. It's not about caching.
Currently, waku/router supports nested routes in a unique way. It determines if it's a leaf route by the existence of children. (We may revisit it later as well as how to support nested routes from the ground.)

So, for now, you need to define your App component like the following:

const App = ({ name = "Anonymous" }) => ({ children }) => {
  if (children) return children;
  return (
    <div style={{ border: "3px red dashed", margin: "1em", padding: "1em" }}>
      <h1>Hello {name}!!</h1>
      <h3>This is a server component.</h3>
    </div>
  );
};

export default App;

[dai-shi]

#124 will improve about caching (= no cache).
#85 (comment) approach is still valid and unchanged.
#124 will introduce a new api in entries.tsx, so it should be less confusing.

[dai-shi]

As I wasn't comfortable with caching, I made another change in #124.
Now, it has layout.tsx and page.tsx convention. So, this issue will officially be solved.
We will no longer need #85 (comment) workaround.