Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Context Provider invalid value #631

Closed
kspeyanski opened this issue Mar 29, 2024 · 5 comments · Fixed by #645
Closed

[BUG] Context Provider invalid value #631

kspeyanski opened this issue Mar 29, 2024 · 5 comments · Fixed by #645
Labels
bug Something isn't working

Comments

@kspeyanski
Copy link

Description:
Context value seems to not be what the Provider has set, but always fallback to the default one, when using use client.

Reproducible sandbox:
https://codesandbox.io/p/devbox/waku-x-kendo-forked-yp6m3f?file=%2Fsrc%2Ftemplates%2Fgrid-page.tsx%3A11%2C11

Steps to reproduce:

  • Start the dev server
  • navigate to the /grid page
  • Observe the context's value

Expected result:

  • The value should equal what's set through the Context.Provider

Actual result:

  • The value is always what's set as a default in the .createContext() call.
@dai-shi
Copy link
Owner

dai-shi commented Mar 29, 2024

Thanks for reporting.
It works in PRD, so it's DEV-only issue.
It works in v0.19.4, so it's probably #552 regression.
@Aslemammad

@dai-shi dai-shi added the bug Something isn't working label Mar 29, 2024
@Aslemammad
Copy link
Contributor

Thank you so much, I'll look into this.

@Aslemammad
Copy link
Contributor

The repro does not work for me

image

@dai-shi
Copy link
Owner

dai-shi commented Mar 29, 2024

Looks like the csb is changed and now the repro page is http://localhost/context.

@Aslemammad
Copy link
Contributor

Nice, I'm taking a look.

dai-shi added a commit that referenced this issue Mar 30, 2024
dai-shi added a commit that referenced this issue Apr 10, 2024
close #631

---------

Co-authored-by: daishi <[email protected]>
Co-authored-by: Daishi Kato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants