fix: don't push "/404" to history

dai-shi · Sep 25, 2024 · 4671527 · 4671527
1 parent f094430
commit 4671527
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/waku/src/router/client.ts b/packages/waku/src/router/client.ts
@@ -431,14 +431,16 @@ const InnerRouter = ({ routerData }: { routerData: RouterData }) => {
       url.pathname = path;
       url.search = query;
       url.hash = '';
-      window.history.pushState(
-        {
-          ...window.history.state,
-          waku_new_path: url.pathname !== window.location.pathname,
-        },
-        '',
-        url,
-      );
+      if (path !== '/404') {
+        window.history.pushState(
+          {
+            ...window.history.state,
+            waku_new_path: url.pathname !== window.location.pathname,
+          },
+          '',
+          url,
+        );
+      }
       changeRoute(parseRoute(url), { skipRefetch: true });
     };
     const listeners = (routerData[1] ||= new Set());