Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: migrate to vite #4

Merged
merged 6 commits into from
May 16, 2024
Merged

examples: migrate to vite #4

merged 6 commits into from
May 16, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented May 14, 2024

we need standalone tsconfig files.

Also migrate from CRA to Vite, which is modern.

close #5

@dai-shi
Copy link
Owner Author

dai-shi commented May 15, 2024

Testing with https://stackblitz.com/github/dai-shi/use-signals/tree/migrate-to-stackblitz/examples/01_counter, and got this:

Error in src/index.tsx (1:1)
Option 'bundler' can only be used when 'module' is set to 'preserve' or to 'es2015' or later.

@dai-shi
Copy link
Owner Author

dai-shi commented May 15, 2024

@dai-shi
Copy link
Owner Author

dai-shi commented May 16, 2024

@hatemhosny
Copy link

hatemhosny commented May 16, 2024

https://livecodes.io/?x=https://github.com/dai-shi/use-signals/tree/migrate-to-stackblitz/examples/01_counter/src works flawlessly. (except that it shows empty HTML tab first.)

You are right. It should not select an empty editor by default.
I will try to improve that.
Also, some improvements can be made in the docs.
Thank you.

@hatemhosny
Copy link

@dai-shi
Copy link
Owner Author

dai-shi commented May 16, 2024

https://livecodes.io/?x=https://github.com/dai-shi/use-signals/blob/migrate-to-stackblitz/examples/01_counter/src/app.tsx

That's reasonable as LiveCodes only works with one tsx file anyway, right?

@dai-shi dai-shi changed the title migrate to stackblitz examples: migrate to vite May 16, 2024
Copy link
Owner Author

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how acceptable it is with the community standard, but I like how it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants