Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client setinfo #83

Merged

Conversation

ArtemIsmagilov
Copy link
Contributor

@mcatanzariti
Copy link
Member

Hello,

Tests are failing.

I'm wondering if this api should be public... I think rustis and its build version could be automatically send to the server.

Cheers,

Michaël

@ArtemIsmagilov
Copy link
Contributor Author

ArtemIsmagilov commented Dec 11, 2024

Hi, @mcatanzariti !

Honestly, I don't know the answer to your question. It seems that the command allows you to specify useful properties about the client in the future. Right now it's only the version and the library name.
I don't even know if it will be possible to specify more useful data for the server in the future.

In fact, this functionality with two arguments is quite poor. I expect that this command from Redis may be needed in the future expansion.

You can hide this functionality if you think it is necessary. It seems to be available in the documentation.
https://valkey.io/commands/client-setinfo/

Thanks for the review and good health to you!

ArtemIsmagilov

@mcatanzariti mcatanzariti merged commit 950bc71 into dahomey-technologies:main Dec 15, 2024
3 checks passed
@ArtemIsmagilov ArtemIsmagilov deleted the add-client-setinfo branch December 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants