Avoid warning when using -rc versions of Git for Windows #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version check was a bit too tight. This fixes dahlbyk#845. Note: it was suggested in that ticket to use a laxer version check, but that looks as if it might have unwanted consequences, so let's give just an inch for starters. Signed-off-by: Johannes Schindelin <[email protected]>
Discovery in posh-git/test/CheckRequirements.Tests.ps1 failed with: System.Management.Automation.RuntimeException: No modules named 'posh-git' are currently loaded.
dahlbyk
approved these changes
Mar 27, 2022
| Describe 'Test-GitVersion' { | ||
| InModuleScope 'posh-git' { | ||
| It 'Returns true for Git for Windows newer than 2.15 (<_>)' -ForEach @( | ||
| 'git version 2.33.0-rc2.windows.1', |
There was a problem hiding this comment.
@dscho can you confirm this is the correct version format? Your commit mentions -rc but the regex was \.rc.
There was a problem hiding this comment.
#860 (comment) has git version 2.32.0.rc1.windows.1. Pushed a commit to support either. 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #845.