Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only default home dir abbreviation to $true on Linux/macOS #801

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Only default home dir abbreviation to $true on Linux/macOS #801

merged 1 commit into from
Oct 22, 2020

Conversation

rkeithhill
Copy link
Collaborator

If enabled, always substitute ~ for the home dir path on all OSs.

Address issue brought up in #746

@rkeithhill
Copy link
Collaborator Author

rkeithhill commented Oct 21, 2020 •
edited
Loading

@dahlbyk Well, this looks a little odd now:

image

Can we change that separator character or maybe just get rid of it?

@dahlbyk
Copy link
Owner

dahlbyk commented Oct 21, 2020

@dahlbyk Well, this looks a little odd now:

image

Can we change that separator character or maybe just get rid of it?

The ~ was introduced in 1ed6d4d due to a Console2 bug that's either long fixed or likely irrelevant—and it's customizable. Let's change to a - by default, or maybe > to roughly mirror what's visible in the prompt?

dahlbyk
dahlbyk approved these changes Oct 21, 2020
View reviewed changes
Copy link
Owner

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving open in case you want to tack on the ~ change. Otherwise feel free to merge.

@rkeithhill
Copy link
Collaborator Author

Here's what a > looks like:

image

image

vs a -

image

image

I dunno. Having > in the title bar seems a bit weird to me while - seems more "titlebar like".

@dahlbyk
Copy link
Owner

dahlbyk commented Oct 21, 2020

Having > in the title bar seems a bit weird to me while - seems more "titlebar like".

Concur. Let's go with -.

@rkeithhill
Only default home dir abbreviation to $true on Linux/macOSIf enabled,…
f626d0a 
… always substitute ~ for the home dir path on all OSs.
@rkeithhill rkeithhill merged commit 4bb8d81 into master Oct 22, 2020
@rkeithhill rkeithhill deleted the rkeithhill/adj-path-abbrev branch October 22, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlbyk dahlbyk dahlbyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkeithhill @dahlbyk