WIP: Reorgs settings using PS v5 classes #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I want to add support for something like this |
rkeithhill
commented
Oct 30, 2017
|
|
||
| AnsiConsole = $Host.UI.SupportsVirtualTerminal -or ($Env:ConEmuANSI -eq "ON") | ||
| $str = "${fg}${bg}${txt}${e}0m" |
There was a problem hiding this comment.
Update to not append ansi terminator if both fg and bg are $null (or empty).
rkeithhill
commented
Oct 30, 2017
| @@ -24,10 +24,31 @@ $AnsiEscape = [char]27 + "[" | |||
| $ColorTranslatorType = 'System.Drawing.ColorTranslator' -as [Type] | |||
| $ColorType = 'System.Drawing.Color' -as [Type] | |||
|
|
|||
| function EscapseAnsiString([string]$AnsiString) { | |||
| if ($PSVersionTable.PSVersion.Major -ge 6) { | |||
| $res = $AnsiString -replace "$([char]0x1B)", '`e' | |||
There was a problem hiding this comment.
Pick either [char]0x1b or [char]27 and stay consistent.
|
I think I will close this in favor of #513 which rounds out the desired functionality for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the existing
developbranch approach to rendering ANSI. The other approaches I tried aren't there yet. Add-Type is too slow on PS Core. Using C# source code is a pain to get built and working cross-platform.This approach uses v5 classes so we would have to drop support for v3/v4. This seems reasonable to me as the primary points of this branch are to support cross-platform PowerShell Core and ANSI.
Before this change, looking at the
$GitPromptSettingsresults in:After this change: