Add test for update to Add-PoshGitToProfile #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks that the command creates the profile parent dir (or any in the path) if they don't exist. The command was modified to create any dir in the path by the addition of the -Force parameter on New-Item.
dahlbyk
force-pushed
the
rkeithhill/add-pester-test-for-create-profile-dir
branch
from
a6eaa43
to
0a72234
Compare
For your consideration... since we already have cleanup infrastructure (for the record, |
|
Nice! I got hung up on $profilePath being a generated filename (not a dir) but yeah, deleting the file and usurping that name for the dirname does make this cleaner. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks that the command creates the profile parent dir (or any in the path) if they don't exist. The command was modified to create any dir in the path by the addition of the -Force parameter on New-Item.
Follow-up on #449