Add-PoshGitToProfile should not modify signed prof #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to address this issue before shipping 0.7.0 - #328 (comment) Merge to develop.
dahlbyk
approved these changes
Feb 19, 2017
src/Utils.ps1
Outdated
| # If the profile script exists and is signed, then we should not modify it | ||
| if (Test-Path -LiteralPath $profilePath) { | ||
| $sig = Get-AuthenticodeSignature $profilePath | ||
| if ($sig.Status -eq [System.Management.Automation.SignatureStatus]::Valid) { |
There was a problem hiding this comment.
Should we warn/abort if $sig.Status is anything other than NotSigned?
There was a problem hiding this comment.
Yup. I'll make that change.
There was a problem hiding this comment.
Well that turned out to be a little ugly as there are three values that can represent an unsigned file (NotValid, UnknownError, IncompatibleFileType) and four values that can represent a signed file. Switching to testing the SignatureType field.
| @@ -82,18 +82,32 @@ function Invoke-Utf8ConsoleCommand([ScriptBlock]$cmd) { | |||
| .OUTPUTS | |||
| None. | |||
| #> | |||
| function Add-PoshGitToProfile([switch]$AllHosts, [switch]$Force, [switch]$WhatIf) { | |||
| function Add-PoshGitToProfile { | |||
| [CmdletBinding(SupportsShouldProcess)] | |||
SignatureStatus appears to have four enum values that correspond to a signed file vs three for not signed. Switching to check the SignatureType value as it will indicate Authenticode when file is Authenticode signed even if the hash doesn't match (been modified previously) or the cert is not trusted / incompatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to address this issue before shipping 0.7.0 - #328 (comment)
Merge to develop.