Only override OutputEncoding if single-byte #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to fix #389 due to apparent bug in .NET. Changes code added in #359.
My hypothesis is that the
[Console]::OutputEncodingoverride is only necessary if we're not already using a multi-byte encoding.I tested this locally by adding
chcp 65001at the start of my$PROFILE. This causes theOutputEncodingoverride to be skipped, and posh-git still handles a UTF8 branch name as expected. Not sure what/how else to test, other than users with a variety of natural console/encoding settings.