Fixed syntax error on setenv calls. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
|
@dahlbyk No problem. Glad to give back. I have some questions about the implementation of the SSH_AGENT_PID and SSH_AUTH_SOCK environment variables in posh-git and I'm trying to figure out where best to post those. Should I create an issue on them? |
Yeah, opening an issue should get you the most 👀 on the question. Feel free to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to understand how posh-git handles environment variables, I found a bug when removing the environment variables. The function calls were separating parameters out with commas when they should be separated by spaces.