Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Get-Process from adding exceptions to $Error when checking if pageant / ssh-agent aren't running #162

Merged
merged 4 commits into from
Nov 13, 2014
Merged

Stop Get-Process from adding exceptions to $Error when checking if pageant / ssh-agent aren't running #162

merged 4 commits into from
Nov 13, 2014

Commits on Nov 9, 2014

  1. Stop Get-Process from adding exceptions to $Error 

    Updating the Get-Process call in GitUtils.ps1 so exceptions aren't added to the global $Error array

This occurs when pageant or ssh-agent aren't running, and therefore there is no process / pid to retrieve. However this is a valid scenario so shouldn't be added to the global $Error array.

Also being more explicit with the check of the returned value from Get-Process
    @paulmarsy
    paulmarsy committed Nov 9, 2014
    Configuration menu
    Copy the full SHA
    22d1fc4 View commit details
    Browse the repository at this point in the history

  2. Revert "Stop Get-Process from adding exceptions to $Error" 

    This reverts commit 22d1fc4.
    @paulmarsy
    paulmarsy committed Nov 9, 2014
    Configuration menu
    Copy the full SHA
    45137de View commit details
    Browse the repository at this point in the history

  3. Modifying the identification of the pageant and ssh-agent processes 

    Changing the identification of the pageant / ssh-agent process so an
error being thrown and silently ignored is not an expected scenario and
allows real errors from calling Get-Process to be seen
    @paulmarsy
    paulmarsy committed Nov 9, 2014
    Configuration menu
    Copy the full SHA
    687cce6 View commit details
    Browse the repository at this point in the history

  4. Removing the unneeded selection of ssh-agent's PID

    @paulmarsy
    paulmarsy committed Nov 9, 2014
    Configuration menu
    Copy the full SHA
    306eed9 View commit details
    Browse the repository at this point in the history