Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Types" tutorial doc to CRAG #5246

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

clairelin135
Copy link
Contributor

@clairelin135 clairelin135 commented Oct 18, 2021

Screenshot #1 (after dagit -f custom_types.py)
Screen Shot 2021-10-18 at 1 21 19 PM
Screenshot #2 (after "We will also see the error message in Dagit:")
Screen Shot 2021-10-18 at 1 17 15 PM
Screenshot #3 (after "Dagit knows how to display and archive structured metadata of this kind for future review:")
Screen Shot 2021-10-18 at 2 01 41 PM

@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/9wSALy5HpEapJwbeC6TJkb299beR
✅ Preview: https://dagster-git-claire-adv-tuttypes-elementl.vercel.app

@clairelin135 clairelin135 changed the title update screenshots and code Migrate "Types" tutorial doc to CRAG Oct 18, 2021
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for screenshots! This looks great.

src="/images/tutorial/custom_types_2_dagit_error_message.png"
width={2880}
height={1596}
alt="job_custom_types_2_dagit_error_message.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we keep the filenames the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, editing

@clairelin135 clairelin135 merged commit 11616b2 into master Oct 19, 2021
@clairelin135 clairelin135 deleted the claire/adv-tut/types branch October 19, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants