Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuring ops tutorial doc to CRAG #5245

Merged
merged 5 commits into from
Oct 19, 2021

Conversation

clairelin135
Copy link
Contributor

@clairelin135 clairelin135 commented Oct 18, 2021

Screenshot #1: (after "Let's enter it into the config editor:")
Screen Shot 2021-10-18 at 12 28 06 PM

Screenshot #2: (after "Go back to the Playground and press Ctrl + Space in order to bring up the typeahead assistant")
Screen Shot 2021-10-18 at 12 51 07 PM

@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/4uE6raCELfynXYHZrMGVBZL8rE27
✅ Preview: https://dagster-git-claire-configuring-ops-doc-elementl.vercel.app

@clairelin135 clairelin135 requested a review from dpeng817 October 18, 2021 19:57
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind posting screenshots of the screenshots is the only thing lol

@@ -670,4 +670,4 @@
}
]
}
]
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if this matters or not, but some linter might get mad at the lack of new line here?

@clairelin135 clairelin135 requested a review from dpeng817 October 18, 2021 21:31
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@clairelin135 clairelin135 merged commit 5fb050f into master Oct 19, 2021
@clairelin135 clairelin135 deleted the claire/configuring-ops-doc branch October 19, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants