-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuring ops tutorial doc to CRAG #5245
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/elementl/dagster/4uE6raCELfynXYHZrMGVBZL8rE27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind posting screenshots of the screenshots is the only thing lol
docs/content-crag/_navigation.json
Outdated
@@ -670,4 +670,4 @@ | |||
} | |||
] | |||
} | |||
] | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk if this matters or not, but some linter might get mad at the lack of new line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Screenshot #1: (after "Let's enter it into the config editor:")
Screenshot #2: (after "Go back to the Playground and press Ctrl + Space in order to bring up the typeahead assistant")